Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Paul Fagerburg.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74257 )
Change subject: rex: add variant gpio tables for variant creation
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The implementation is little different in Rex in terms GPIO (compared to the Brya) […]
Ah I see. But I am not sure the codes generated by new_variants will support this scheme?
+Paul for comment as well.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc098f8d480ac3e1835b00861fd844d97f281a8
Gerrit-Change-Number: 74257
Gerrit-PatchSet: 1
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Comment-Date: Mon, 10 Apr 2023 17:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment