EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37693 )
Change subject: mb/google/drallion: Enable/disable GPIO clock gating ......................................................................
mb/google/drallion: Enable/disable GPIO clock gating
Before the system enters S0ix/S3, each GPIO community will have its dynamic clock gating turned on. Upon return to S0, the dynamic clock gating will be turned back off.
BUG=b:144002424 TEST=measure power comsumption by HW.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3b6e91d04bea6ac0c9bfc6b4cd67abb25cba13d9 --- M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37693/1
diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl index dbe487e..93dc127 100644 --- a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl @@ -42,10 +42,15 @@ _SB.PCI0.CTXS (TS_PD) /* Clear HDMI power to avoid leakage */ _SB.PCI0.CTXS (HDMI_PD) + /* Enable GPIO PM */ + _SB.PCI0.GCPM (MISCCFG_ENABLE_GPIO_PM_CONFIG) }
/* Method called from _WAK prior to wakeup */ Method (MWAK, 1) { _SB.PCI0.LPCB.EC0.WAK (Arg0) + + /* Disable GPIO PM */ + _SB.PCI0.GCPM (0) }
Hello Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37693
to look at the new patch set (#2).
Change subject: mb/google/drallion: Enable/disable GPIO clock gating ......................................................................
mb/google/drallion: Enable/disable GPIO clock gating
Before the system enters S0ix/S3, each GPIO community will have its dynamic clock gating turned on. Upon return to S0, the dynamic clock gating will be turned back off.
BUG=b:144002424 TEST=measure power consumption by HW.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I3b6e91d04bea6ac0c9bfc6b4cd67abb25cba13d9 --- M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37693/2
EricR Lai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37693 )
Change subject: mb/google/drallion: Enable/disable GPIO clock gating ......................................................................
Abandoned
move to doc level
-
EricR Lai (Code Review)