Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86035?usp=email )
Change subject: soc/mediatek: Modify MT6685 pmic driver ......................................................................
soc/mediatek: Modify MT6685 pmic driver
Use mt6685_write8 instead of mt6685_write16 when setting the protect key, only need 1 byte needs to be written to the register each time.
TEST=Build pass. BUG=b:388666377
Signed-off-by: Lu Tang lu.tang@mediatek.corp-partner.google.com Change-Id: Ib6e79642e813e7a1f0d38243e9c4db5a699cc9e3 --- M src/soc/mediatek/common/mt6685.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/86035/1
diff --git a/src/soc/mediatek/common/mt6685.c b/src/soc/mediatek/common/mt6685.c index 7d17556..71ef476 100644 --- a/src/soc/mediatek/common/mt6685.c +++ b/src/soc/mediatek/common/mt6685.c @@ -74,7 +74,7 @@ static void mt6685_unlock(bool unlock) { for (int i = 0; i < ARRAY_SIZE(key_protect_setting); i++) - mt6685_write16(key_protect_setting[i].addr, + mt6685_write8(key_protect_setting[i].addr, unlock ? key_protect_setting[i].val : 0); }