Change in coreboot[master]: lib: hardwaremain: Call exception_init() as soon as possible

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Asami Doi (Code Review)

22 Aug 2019 22 Aug '19

4:22 a.m.

Asami Doi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

lib: hardwaremain: Call exception_init() as soon as possible

Call exception_init() before calling cbmem_initialize() because ARMv8 on QEMU uses an exception handler to detect a ram size.

Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab --- M src/lib/hardwaremain.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35022/1

diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index 2881162..d46cdc0 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -454,6 +454,8 @@ * it is the very first thing done in ramstage.*/ console_init();

+ exception_init(); + post_code(POST_CONSOLE_READY);

/* @@ -472,8 +474,6 @@ #if CONFIG(HAVE_ACPI_RESUME) acpi_is_wakeup(); #endif - - exception_init(); threads_initialize();

/* Schedule the static boot state entries. */

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

22 Aug 22 Aug

6:42 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:

https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c@457 PS1, Line 457: exception_init(); Place this after the post_code(POST_CONSOLE_READY)? In case things go wrong with exception init at least the post code would serve as a indicator.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 1 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 22 Aug 2019 04:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Asami Doi (Code Review)

6:52 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35022

to look at the new patch set (#2).

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

lib: hardwaremain: Call exception_init() as soon as possible

Call exception_init() before calling cbmem_initialize() because ARMv8 on QEMU uses an exception handler to detect a ram size.

Signed-off-by: Asami Doi d0iasm.pub@gmail.com Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab --- M src/lib/hardwaremain.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35022/2

Asami Doi (Code Review)

6:54 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35022

to look at the new patch set (#3).

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

lib: hardwaremain: Call exception_init() as soon as possible

Call exception_init() before calling cbmem_initialize() because ARMv8 on QEMU uses an exception handler to detect a ram size.

Signed-off-by: Asami Doi d0iasm.pub@gmail.com Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab --- M src/lib/hardwaremain.c 1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/35022/3

Asami Doi (Code Review)

6:56 a.m.

Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:

https://review.coreboot.org/c/coreboot/+/35022/1/src/lib/hardwaremain.c@457 PS1, Line 457: exception_init();

...

Place this after the post_code(POST_CONSOLE_READY)? In case things go wrong with exception init at l […]

Yes, it makes sense. I moved it after the post_code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-CC: Raul Rangel rrangel@chromium.org Gerrit-Comment-Date: Thu, 22 Aug 2019 04:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Raul Rangel (Code Review)

5:20 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-CC: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Thu, 22 Aug 2019 15:20:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

7:52 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Thu, 22 Aug 2019 17:52:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:11 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 3 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Aug 2019 19:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

23 Aug 23 Aug

10:17 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35022 )

Change subject: lib: hardwaremain: Call exception_init() as soon as possible ......................................................................

lib: hardwaremain: Call exception_init() as soon as possible

Call exception_init() before calling cbmem_initialize() because ARMv8 on QEMU uses an exception handler to detect a ram size.

Signed-off-by: Asami Doi d0iasm.pub@gmail.com Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Reviewed-on: https://review.coreboot.org/c/coreboot/+/35022 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/lib/hardwaremain.c 1 file changed, 2 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Julius Werner: Looks good to me, approved Raul Rangel: Looks good to me, approved

diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c index 3c6fb93..a4c154e 100644 --- a/src/lib/hardwaremain.c +++ b/src/lib/hardwaremain.c @@ -451,9 +451,10 @@ /* console_init() MUST PRECEDE ALL printk()! Additionally, ensure * it is the very first thing done in ramstage.*/ console_init(); - post_code(POST_CONSOLE_READY);

+ exception_init(); + /* * CBMEM needs to be recovered because timestamps, ACPI, etc rely on * the cbmem infrastructure being around. Explicitly recover it. @@ -470,8 +471,6 @@ #if CONFIG(HAVE_ACPI_RESUME) acpi_is_wakeup(); #endif - - exception_init(); threads_initialize();

/* Schedule the static boot state entries. */

-- To view, visit https://review.coreboot.org/c/coreboot/+/35022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If010234a6576414e7e174c075b599a4aa4c19eab Gerrit-Change-Number: 35022 Gerrit-PatchSet: 4 Gerrit-Owner: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Asami Doi d0iasm.pub@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2079

days inactive

2080

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Asami Doi (Code Review)
Furquan Shaikh (Code Review)
Julius Werner (Code Review)
Patrick Georgi (Code Review)
Raul Rangel (Code Review)