Attention is currently required from: Subrata Banik.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56121 )
Change subject: arch/x86: smbios write 7 table using deterministic cache functions
......................................................................
Patch Set 10:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/56121/comment/de611603_b37bdf7f
PS10, Line 813: continue;
Is it an infinite loop here when fill_cpu_cache_info() return false (will happen if cpu_get_cache_info_leaf() returns 0).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedbd3b745629dea57c3ad6b0d187eab2bcc3f7d3
Gerrit-Change-Number: 56121
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Piotr Król
piotr.krol@3mdeb.com
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 06:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment