Attention is currently required from: Subrata Banik, Kane Chen, Tim Wawrzynczak, Arthur Heymans.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 )
Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
......................................................................
Patch Set 4:
(2 comments)
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/64467/comment/4435e0df_28a2fa42
PS3, Line 339: lapicid
Use a variable instead of calling this over and over...
Done
https://review.coreboot.org/c/coreboot/+/64467/comment/220efbc9_925780a9
PS3, Line 358: lapicid
why not calling into `cpu_index()` to know the CPU ID instead APIC ID, which would be difficult to k […]
i checked cpu_index function, there is loop inside to compare apic id. i feel it's too much.
The apic_id here is to indicate what cpu is running the task, so i guess apic_id should be good enough?
thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1
Gerrit-Change-Number: 64467
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment