Change in coreboot[master]: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

List overview All Threads
Download

newer

older

Change in coreboot[4.11_branch]:...

Kane Chen (Code Review)

2 Dec 2019 2 Dec '19

7:02 a.m.

Hello Subrata Banik, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37088

to review the following change.

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252.

Reason for revert: This change breaks runtime s0ix.

Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37088/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index a2831e1..7382209 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,8 +58,6 @@

- register "PchPmSlpS0Vm075VSupport" = "1" - # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Furquan Shaikh (Code Review)

2 Dec 2 Dec

6:27 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG@11 PS1, Line 11: This change breaks runtime s0ix. Is there a bug # for this?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Dec 2019 18:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

3 Dec 3 Dec

2:15 a.m.

Hello Subrata Banik, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37088

to look at the new patch set (#2).

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252.

Reason for revert: This change breaks runtime s0ix.

BUG=b:134092071 TEST=Check slp_s0 residency increased when system is idle.

Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Signed-off-by: Kane Chen kane.chen@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37088/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

2:17 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG@11 PS1, Line 11: This change breaks runtime s0ix.

...

Is there a bug # for this?

hi Furquan, i'm going to use the orig bug to check b:141831197 thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Dec 2019 02:17:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:28 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Dec 2019 03:28:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

3:29 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37088/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37088/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=hatch

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Dec 2019 03:29:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

3:33 a.m.

Hello Subrata Banik, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37088

to look at the new patch set (#3).

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252.

Reason for revert: This change breaks runtime s0ix.

BRANCH=hatch BUG=b:134092071 TEST=Check slp_s0 residency increased when system is idle.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37088/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

3:09 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 3:

I'm a little confused, I don't see any discussion in the bug listed as to where this setting is affecting runtime S0ix.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 03 Dec 2019 15:09:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

3:20 p.m.

Hello Subrata Banik, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37088

to look at the new patch set (#4).

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252.

Reason for revert: This change breaks runtime s0ix.

BRANCH=hatch BUG=b:141831197 TEST=Check slp_s0 residency increased when system is idle.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37088/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

3:21 p.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 4:

...

Patch Set 3:

I'm a little confused, I don't see any discussion in the bug listed as to where this setting is affecting runtime S0ix.

sorry, i posted wrong issue number. i just fixed it

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 03 Dec 2019 15:21:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kane Chen (Code Review)

5 Dec 5 Dec

5:24 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 4:

(2 comments)

...

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37088/1//COMMIT_MSG@11 PS1, Line 11: This change breaks runtime s0ix.

...

hi Furquan, […]

Done

https://review.coreboot.org/c/coreboot/+/37088/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37088/2//COMMIT_MSG@12 PS2, Line 12:

...

BRANCH=hatch

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 05 Dec 2019 05:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kane Chen kane.chen@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Kane Chen (Code Review)

5:24 a.m.

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Patch Set 4:

could we merge this? thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Thu, 05 Dec 2019 05:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:50 a.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37088 )

Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ......................................................................

Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"

This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252.

Reason for revert: This change breaks runtime s0ix.

BRANCH=hatch BUG=b:141831197 TEST=Check slp_s0 residency increased when system is idle.

Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Signed-off-by: Kane Chen kane.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37088 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

- register "PchPmSlpS0Vm075VSupport" = "1" - # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS |

-- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: merged

1819

days inactive

1822

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

Furquan Shaikh (Code Review)
Kane Chen (Code Review)
Tim Wawrzynczak (Code Review)