build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26942 )
Change subject: {arch,commonlib,cpu,device,drivers,lib,nb,sb}: Use "foo *bar" instead of "foo* bar" ......................................................................
Patch Set 5:
(29 comments)
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h File src/device/oprom/yabel/compat/of.h:
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@3... PS5, Line 38: #define p32cast (int) (unsigned long) (void *) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 62: int of_read(ihandle_t , void *, int); space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 62: int of_read(ihandle_t , void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 62: int of_read(ihandle_t , void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 62: int of_read(ihandle_t , void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 63: int of_write(ihandle_t, void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 64: int of_seek(ihandle_t, int, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int ); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int ); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int ); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@6... PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int ); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short ); function definition argument 'char *' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short ); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@7... PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short ); function definition argument 'unsigned short' should also have an identifier name
https://review.coreboot.org/#/c/26942/5/src/northbridge/amd/amdht/ht_wrapper... File src/northbridge/amd/amdht/ht_wrapper.c:
https://review.coreboot.org/#/c/26942/5/src/northbridge/amd/amdht/ht_wrapper... PS5, Line 58: static const char *event_class_string_decodes[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb800/late.... File src/southbridge/amd/cimx/sb800/late.c:
https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb800/late.... PS5, Line 46: * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void *pConfig) line over 80 characters
https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb900/late.... File src/southbridge/amd/cimx/sb900/late.c:
https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb900/late.... PS5, Line 41: * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig) line over 80 characters