Attention is currently required from: Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70797 )
Change subject: cpu/x86/mtrr: use lapicid instead of cpu_index calls
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/70797/comment/5517daa2_068588bf
PS1, Line 295: unsigned int cpu_idx = lapicid();
nit: I know this was asked for in the original patch, but it is only used one more time in this func […]
it's used in a loop, so every loop iteration would do the call. since the result will be the same every time, it makes sense to me to only do the call once and then use the result from the local variable
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d226704051ab171891775a618ce7897b74fde16
Gerrit-Change-Number: 70797
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 14 Dec 2022 23:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment