Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Christian Walter, Julius Werner, Arthur Heymans, Andrey Petrov, Fred Reitberger, Yu-Ping Wu, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63375 )
Change subject: [RFC] CBMEM: Have INIT_HOOKS in every stage ......................................................................
Patch Set 3:
(6 comments)
File src/include/cbmem.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/2f0d8b23_895b669d PS3, Line 110: #define _CBMEM_INIT_HOOK_UNUSED(init_fn_) __attribute__((unused)) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/653a8a29_32d9fc24 PS3, Line 113: #define _CBMEM_INIT_HOOK(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/f699c833_2cca6369 PS3, Line 119: #define _CBMEM_INIT_HOOK_EARLY(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/72c1ce6f_3fae2636 PS3, Line 124: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/954a4574_b3218c9c PS3, Line 126: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK_UNUSED(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145631): https://review.coreboot.org/c/coreboot/+/63375/comment/6d55958d_5da0f527 PS3, Line 130: #define CBMEM_INIT_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs
-
build bot (Jenkins) (Code Review)