Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner, Sudheer Amrabadi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 )
Change subject: qualcomm/sc7280: Add support for edp and mdp driver
......................................................................
Patch Set 33:
(2 comments)
File src/soc/qualcomm/sc7280/display/edp_ctrl.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150529):
https://review.coreboot.org/c/coreboot/+/61342/comment/3d650527_7640949a
PS33, Line 187: #define DP_CHANNEL_EQ_BITS (DP_LANE_CR_DONE | \
please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/display/mdssreg.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150529):
https://review.coreboot.org/c/coreboot/+/61342/comment/fd9ca624_c44f97c2
PS33, Line 469: SW_PIX_EXT_OVERRIDE = BIT(31),
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89abb76028766b19450e756889a5d7776106f95
Gerrit-Change-Number: 61342
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi Kumar Bokka
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Thu, 02 Jun 2022 11:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment