Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT ......................................................................
mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT
Selecting VBOOT_LID_SWITCH under BOARD_GOOGLE_BASEBOARD_HATCH creates a requirement for VBOOT, and prevents building in the non-vboot/non-ChromeOS case. Correct this so building without vboot/ChromeOS works properly
Change-Id: I060e82185997bce451648173dd97dd6a3d5d237f Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42137/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 46aa4d1..2443114 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -3,7 +3,7 @@ def_bool n select BOARD_GOOGLE_HATCH_COMMON select SYSTEM_TYPE_LAPTOP - select VBOOT_LID_SWITCH + select VBOOT_LID_SWITCH if VBOOT
config BOARD_GOOGLE_BASEBOARD_PUFF def_bool n
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT ......................................................................
Patch Set 1:
thought about dropping the selection from the baseboard completely, since selecting CHROMEOS will select VBOOT_LID_SWITCH as well, but wasn't sure which was preferred
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT ......................................................................
Patch Set 1: Code-Review+1
Looks good, but I'd like to hear Furquan's thoughts
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: make VBOOT_LID_SWITCH depend on VBOOT ......................................................................
Patch Set 1:
Patch Set 1:
thought about dropping the selection from the baseboard completely, since selecting CHROMEOS will select VBOOT_LID_SWITCH as well, but wasn't sure which was preferred
Yeah, I think we should drop this from BOARD_GOOGLE_BASEBOARD_HATCH because as you mentioned this is already selected by CHROMEOS. I had this change in my local repo, but never got a chance to push it.
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Paul Menzel, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42137
to look at the new patch set (#2).
Change subject: mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard ......................................................................
mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard
Selecting VBOOT_LID_SWITCH under BOARD_GOOGLE_BASEBOARD_HATCH creates a requirement for VBOOT, and prevents building in the non-vboot/non-ChromeOS case. As this symbol is already selected by CHROMEOS below, there's no need for the baseboard (and only one of the two) to select it, so don't.
Change-Id: I060e82185997bce451648173dd97dd6a3d5d237f Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42137/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42137 )
Change subject: mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard ......................................................................
mb/google/hatch: drop VBOOT_LID_SWITCH from hatch baseboard
Selecting VBOOT_LID_SWITCH under BOARD_GOOGLE_BASEBOARD_HATCH creates a requirement for VBOOT, and prevents building in the non-vboot/non-ChromeOS case. As this symbol is already selected by CHROMEOS below, there's no need for the baseboard (and only one of the two) to select it, so don't.
Change-Id: I060e82185997bce451648173dd97dd6a3d5d237f Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42137 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 46aa4d1..5821b76 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -3,7 +3,6 @@ def_bool n select BOARD_GOOGLE_HATCH_COMMON select SYSTEM_TYPE_LAPTOP - select VBOOT_LID_SWITCH
config BOARD_GOOGLE_BASEBOARD_PUFF def_bool n
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)