Change in coreboot[master]: mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43118 )

Change subject: mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init
......................................................................

mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init

This change drops the check for ENV_RAMSTAGE in mainboard_ec_init()
since it is included only in ramstage. Also, the content of
ramstage_ec_init() is moved into mainboard_ec_init().

Change-Id: I282fb07a80f4de6064a544f6dd58e8f973a597b9
Signed-off-by: Furquan Shaikh 
---
M src/mainboard/google/zork/ec.c
1 file changed, 1 insertion(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43118/1

diff --git a/src/mainboard/google/zork/ec.c b/src/mainboard/google/zork/ec.c
index 4c4329d..d770d27 100644
--- a/src/mainboard/google/zork/ec.c
+++ b/src/mainboard/google/zork/ec.c
@@ -3,10 +3,9 @@
 #include <acpi/acpi.h>
 #include <console/console.h>
 #include <ec/google/chromeec/ec.h>
-#include <soc/southbridge.h>
 #include <variant/ec.h>

-static void ramstage_ec_init(void)
+void mainboard_ec_init(void)
 {
    const struct google_chromeec_event_info info = {
    	.log_events = MAINBOARD_EC_LOG_EVENTS,
@@ -19,9 +18,3 @@

google_chromeec_events_init(&info, acpi_is_wakeup_s3());
 }
-
-void mainboard_ec_init(void)
-{
-	if (ENV_RAMSTAGE)
-		ramstage_ec_init();
-}

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43118 )

Change subject: mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43118 )

Change subject: mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init
......................................................................

mb/google/zork: Drop check for ENV_RAMSTAGE in mainboard_ec_init

This change drops the check for ENV_RAMSTAGE in mainboard_ec_init()
since it is included only in ramstage. Also, the content of
ramstage_ec_init() is moved into mainboard_ec_init().

Change-Id: I282fb07a80f4de6064a544f6dd58e8f973a597b9
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43118
Reviewed-by: Aaron Durbin 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/zork/ec.c
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/mainboard/google/zork/ec.c b/src/mainboard/google/zork/ec.c
index 4c4329d..d770d27 100644
--- a/src/mainboard/google/zork/ec.c
+++ b/src/mainboard/google/zork/ec.c
@@ -3,10 +3,9 @@
 #include <acpi/acpi.h>
 #include <console/console.h>
 #include <ec/google/chromeec/ec.h>
-#include <soc/southbridge.h>
 #include <variant/ec.h>

-static void ramstage_ec_init(void)
+void mainboard_ec_init(void)
 {
    const struct google_chromeec_event_info info = {
    	.log_events = MAINBOARD_EC_LOG_EVENTS,
@@ -19,9 +18,3 @@

google_chromeec_events_init(&info, acpi_is_wakeup_s3());
 }
-
-void mainboard_ec_init(void)
-{
-	if (ENV_RAMSTAGE)
-		ramstage_ec_init();
-}