Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39846 )
Change subject: mb/kontron/mal10: increase I2C bus frequency ......................................................................
mb/kontron/mal10: increase I2C bus frequency
In accordance with the changes in kontron-ec [1], we can increase the frequency of the I2C bus to reduce the read time of the EEPROM during initialization of the board.
Change-Id: Iaa194b9497fe046744e1e298535e2493ab75b6cd Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39846/1
diff --git a/src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb b/src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb index a2cd3b3..47537ea 100644 --- a/src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb +++ b/src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb @@ -98,6 +98,8 @@ chip ec/kontron/kempld register "uart[0]" = "{ KEMPLD_UART_3F8, 4 }" register "uart[1]" = "{ KEMPLD_UART_2F8, 3 }" + register "i2c_freq" = "400" # kHz + device generic 0.0 on end # UART #0 device generic 0.1 on end # UART #1 device generic 1.0 on end # I2C
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39846 )
Change subject: mb/kontron/mal10: increase I2C bus frequency ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39846/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39846/1//COMMIT_MSG@7 PS1, Line 7: mb/kontron/mal10: increase I2C bus frequency … to 400 kHz
https://review.coreboot.org/c/coreboot/+/39846/1//COMMIT_MSG@9 PS1, Line 9: In accordance with the changes in kontron-ec [1], we can increase the The reference is missing.
https://review.coreboot.org/c/coreboot/+/39846/1//COMMIT_MSG@11 PS1, Line 11: initialization of the board. What is the time reduction in your measurements?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39846
to look at the new patch set (#2).
Change subject: mb/kontron/mal10: increase I2C bus frequency to 400 kHz ......................................................................
mb/kontron/mal10: increase I2C bus frequency to 400 kHz
In accordance with the changes in kontron-ec [1], we can increase the frequency of the I2C bus to reduce the read time of the EEPROM during initialization of the board.
[1] https://review.coreboot.org/c/coreboot/+/39845
Change-Id: Iaa194b9497fe046744e1e298535e2493ab75b6cd Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/kontron/mal10/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39846/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39846
to look at the new patch set (#3).
Change subject: mb/kontron/mal10: increase I2C bus frequency to 400 kHz ......................................................................
mb/kontron/mal10: increase I2C bus frequency to 400 kHz
In accordance with the changes in kontron-ec [1], we can increase the frequency of the I2C bus to reduce the read time of the EEPROM during initialization of the board.
[1] https://review.coreboot.org/c/coreboot/+/39845
Change-Id: Iaa194b9497fe046744e1e298535e2493ab75b6cd Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/kontron/mal10/variants/mal10/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39846/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39846
to look at the new patch set (#12).
Change subject: mb/kontron/mal10: increase I2C bus frequency to 400 kHz ......................................................................
mb/kontron/mal10: increase I2C bus frequency to 400 kHz
In accordance with the changes in kontron-ec [1], we can use Fast-mode stantart [2] for I2C with a bit rate up to 400 kbit/s.
[1] https://review.coreboot.org/c/coreboot/+/39845 [2] I2C-bus specification and user manual, doc #UM10204, Rev. 6, 4 April 2014.
Change-Id: Iaa194b9497fe046744e1e298535e2493ab75b6cd Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/kontron/mal10/variants/mal10/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39846/12
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39846
to look at the new patch set (#13).
Change subject: mb/kontron/mal10: increase I2C bus frequency to 400 kHz ......................................................................
mb/kontron/mal10: increase I2C bus frequency to 400 kHz
In accordance with the changes in kontron-ec [1], we can use Fast-mode stantart [2] for I2C with a bit rate up to 400 kbit/s.
[1] https://review.coreboot.org/c/coreboot/+/39845 [2] I2C-bus specification and user manual, doc #UM10204, Rev. 6, 4 April 2014.
Change-Id: Iaa194b9497fe046744e1e298535e2493ab75b6cd Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/kontron/mal10/variants/mal10/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/39846/13
Maxim Polyakov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39846 )
Change subject: mb/kontron/mal10: increase I2C bus frequency to 400 kHz ......................................................................
Abandoned
Added to CB:39133
-
Maxim Polyakov (Code Review) -
Paul Menzel (Code Review)