Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
spi: Add Winbond W25Q128JW_DTR SPI ROM support
BUG=None TEST=Boot with W24Q128JW_DTR and check MRC data save/restore works.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ica6344556e5de94555b95dd7c6df5600614811e2 --- M src/drivers/spi/winbond.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36762/1
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index 00a7bf9..e0fd272 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -262,6 +262,17 @@ .bp_bits = 3, }, { + .id = 0x8018, + .l2_page_size_shift = 8, + .pages_per_sector_shift = 4, + .sectors_per_block_shift = 4, + .nr_blocks_shift = 8, + .name = "W25Q128JW", + .dual_spi = 1, + .protection_granularity_shift = 18, + .bp_bits = 3, + }, + { .id = 0x4019, .l2_page_size_shift = 8, .pages_per_sector_shift = 4,
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 265: .id = 0x8018, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 265: .id = 0x8018, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 266: .l2_page_size_shift = 8, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 266: .l2_page_size_shift = 8, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 267: .pages_per_sector_shift = 4, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 267: .pages_per_sector_shift = 4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 268: .sectors_per_block_shift = 4, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 268: .sectors_per_block_shift = 4, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 269: .nr_blocks_shift = 8, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 269: .nr_blocks_shift = 8, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 270: .name = "W25Q128JW", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 270: .name = "W25Q128JW", please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 271: .dual_spi = 1, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 271: .dual_spi = 1, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 272: .protection_granularity_shift = 18, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 272: .protection_granularity_shift = 18, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 273: .bp_bits = 3, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 273: .bp_bits = 3, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 274: }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36762/1/src/drivers/spi/winbond.c@2... PS1, Line 274: }, please, no spaces at the start of a line
Peichao Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
spi: Add Winbond W25Q128JW_DTR SPI ROM support
BUG=None TEST=Boot with W24Q128JW_DTR and check MRC data save/restore works.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ica6344556e5de94555b95dd7c6df5600614811e2 --- M src/drivers/spi/winbond.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36762/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36762
to look at the new patch set (#3).
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
spi: Add Winbond W25Q128JW_DTR SPI ROM support
BUG=b:144297264 TEST=Boot with W24Q128JW_DTR and check MRC data save/restore works.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ica6344556e5de94555b95dd7c6df5600614811e2 --- M src/drivers/spi/winbond.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36762/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36762
to look at the new patch set (#4).
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
spi: Add Winbond W25Q128JW_DTR SPI ROM support
BUG=b:144297264 TEST=Boot with W25Q128JW_DTR and check MRC data save/restore works.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ica6344556e5de94555b95dd7c6df5600614811e2 --- M src/drivers/spi/winbond.c 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/36762/4
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36762 )
Change subject: spi: Add Winbond W25Q128JW_DTR SPI ROM support ......................................................................
spi: Add Winbond W25Q128JW_DTR SPI ROM support
BUG=b:144297264 TEST=Boot with W25Q128JW_DTR and check MRC data save/restore works.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ica6344556e5de94555b95dd7c6df5600614811e2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36762 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/drivers/spi/winbond.c 1 file changed, 11 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index fa9140e..9e45117 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -262,6 +262,17 @@ .bp_bits = 3, }, { + .id = 0x8018, + .l2_page_size_shift = 8, + .pages_per_sector_shift = 4, + .sectors_per_block_shift = 4, + .nr_blocks_shift = 8, + .name = "W25Q128JW", + .dual_spi = 1, + .protection_granularity_shift = 18, + .bp_bits = 3, + }, + { .id = 0x4019, .l2_page_size_shift = 8, .pages_per_sector_shift = 4,
-
build bot (Jenkins) (Code Review) -
Edward O'Callaghan (Code Review)
-
Patrick Georgi (Code Review)
-
Peichao Li (Code Review)