Attention is currently required from: Jason Glenesk, Marshall Dawson, Angel Pons. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49781 )
Change subject: soc/amd/cezanne: add pci_devs.h ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/cezanne/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/49781/comment/3ae985e8_bc725249 PS1, Line 129: #define DF_F0_DEVFN PCI_DEVFN(DF_DEV, 0) : #define SOC_DF_F0_DEV _SOC_DEV(DF_DEV, 0)
Parametrized macros can be helpful in loops. […]
yep, there's a mask applied, but that might cause some possibly hard to find malfunction for function numbers > 7. i had a look at picasso and there's no function looping over data fabric pci functions and i also tried to stay rather close to the code in picasso to keep the platforms as consistent as possible. If there will be some functionality added that would need that, it would be a good idea to change the multiple defines to two macros though
-
Felix Held (Code Review)