build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39195 )
Change subject: mb/intel/jasperlake_rvp: memory config for JSLRVP ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 41: }; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 41: }; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 45: if ( board_id == jsl_ddr4 ) space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 45: if ( board_id == jsl_ddr4 ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 47: else if ( board_id == jsl_lpddr4 ) space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 47: else if ( board_id == jsl_lpddr4 ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/39195/4/src/mainboard/intel/jasperl... PS4, Line 50: die(" Unsupported Board id : 0x%x \n", board_id); unnecessary whitespace before a quoted newline
-
build bot (Jenkins) (Code Review)