Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36211 )
Change subject: cpu/intel/car: Add EC software sync to Intel romstage ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
Patch Set 1: Code-Review-1
(3 comments)
Romstage starts here for all Intel platforms. I don't think it makes sense to put platforms specific things here.
That's fair. I'll drop this patch and look into that.
The alternative is to add call points to all mainboard_romstage_entry() code which is also decoupled from the Kconfig itself. i.e. selecting Kconfig won't necessarily make things work generically.
https://review.coreboot.org/c/coreboot/+/36211/1/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/36211/1/src/cpu/intel/car/romstage.... PS1, Line 62: "Failed to sync EC!\n");
On platforms without C_ENVIRONMENT_BOOTBLOCK console is not initialized here.
Yes, but that also applies to the printk()s everywhere in this file. console_init() is called below so the assumption is that either console is there or isn't.
-
Aaron Durbin (Code Review)