Change in ...coreboot[master]: vendorcode/eltan: Add vendor code for measured and verified boot
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30218 )
Change subject: vendorcode/eltan: Add vendor code for measured and verified boot ......................................................................
Patch Set 8:
Patch Set 8:
Patch Set 7:
BTW, you can add all the related patches to the same gerrit topic so that it is easier to keep track of them. There is also the option of using patch trains, so that you build on previous, not yet merged patches. It is good for reviewing as well, since one can follow the order in which the code was added.
Use same gerrit topic for all patches? Do you have an example of 'patch train'? Or you mean to rebase a patch on other patch?
A patch train is (if I understand the concept properly) a group of patches which follow each other. The idea is to divide a very large patchset into a series of steps to reach the same point as the big patchset, but with each patch doing one logical change. The idea is that each patch train builds on top of the previous one (sort of laying bricks one atop the other).
I see you added a topic to all the patches already, which is good. I am not sure how you work on the patches, but to put them together in a train I would:
- Clean the local git repo - Cherry-pick each patch in order (each patch is a building block) - When all are cherry-picked, push to gerrit
I hope this helps.
-
Angel Pons (Code Review)