Change in ...coreboot[master]: sb,soc/intel: Fix flashconsole on older platforms

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21107 )

Change subject: sb,soc/intel: Fix flashconsole on older platforms
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/#/c/21107/16//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/21107/16//COMMIT_MSG@17 
PS16, Line 17: - soc/fsp_{baytrail,broadwell_de}: select NO_CAR_GLOBAL_MIGRATION
> which global variables? […]

If you return into romstage execution after CAR teardown, you are not allowed to select NO_CAR_GLOBAL_MIGRATION.

Subsystems like consoles (CBMEM, usbdebug) and timestamps and possibly even udelay() break otherwise. It's not strictly variables tagged with CAR_GLOBAL that break.

FSP1.0 takes special handling in cpu/x86/car.c to have consoles and timestamps survive over the teardown.