Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29857 )
Change subject: src/soc/intel/braswell: Use DEVICE_NOOP ......................................................................
src/soc/intel/braswell: Use DEVICE_NOOP
Use already defined DEVICE_NOOP instead.
Change-Id: Ie6182f273cba3073c84a502c34a002dee6122c2f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/29857 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/braswell/chip.c 1 file changed, 3 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/soc/intel/braswell/chip.c b/src/soc/intel/braswell/chip.c index 7a63b5b..b7f6d4d 100644 --- a/src/soc/intel/braswell/chip.c +++ b/src/soc/intel/braswell/chip.c @@ -37,12 +37,10 @@ .scan_bus = pci_domain_scan_bus, };
-static void cpu_bus_noop(struct device *dev) { } - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = soc_init_cpus };