Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
3rdparty/amd_blobs: Move pointer to 0.8.5.7B
BUG=b:162057232
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ifd4ac0655f7ada5ec10a266fdb2b930861959215 --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/44040/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 1ac6d42..70fc3cb 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 1ac6d42bf336af639ae849933cbb818e51b1ffd1 +Subproject commit 70fc3cb79cc025895c897e13bb15fa3d89a23d48
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG@7 PS1, Line 7: Move pointer to 0.8.5.7B Don't you need to wait for this to be submitted: https://review.coreboot.org/c/amd_blobs/+/44034?
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG@7 PS1, Line 7: Move pointer to 0.8.5.7B
Don't you need to wait for this to be submitted: https://review.coreboot. […]
Yes, of course that needs to go in first. I'm not aware of a way to order merges, like with a Cq-Depend, with coreboot.org. I'll leave this comment unresolved for now, and that should have a similar effect.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44040/1/3rdparty/amd_blobs File 3rdparty/amd_blobs:
https://review.coreboot.org/c/coreboot/+/44040/1/3rdparty/amd_blobs@1 PS1, Line 1: Subproject commit 70fc3cb79cc025895c897e13bb15fa3d89a23d48 Won't the hash get updated when it gets merged into the amd_blobs repo?
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44040/1//COMMIT_MSG@7 PS1, Line 7: Move pointer to 0.8.5.7B
Yes, of course that needs to go in first. […]
Done
https://review.coreboot.org/c/coreboot/+/44040/1/3rdparty/amd_blobs File 3rdparty/amd_blobs:
https://review.coreboot.org/c/coreboot/+/44040/1/3rdparty/amd_blobs@1 PS1, Line 1: Subproject commit 70fc3cb79cc025895c897e13bb15fa3d89a23d48
Won't the hash get updated when it gets merged into the amd_blobs repo?
Ack
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44040 )
Change subject: 3rdparty/amd_blobs: Move pointer to 0.8.5.7B ......................................................................
3rdparty/amd_blobs: Move pointer to 0.8.5.7B
BUG=b:162057232
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ifd4ac0655f7ada5ec10a266fdb2b930861959215 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44040 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/amd_blobs 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 1ac6d42..70fc3cb 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 1ac6d42bf336af639ae849933cbb818e51b1ffd1 +Subproject commit 70fc3cb79cc025895c897e13bb15fa3d89a23d48
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)