Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35381 )
Change subject: intel/broadwell: Replace some __PRE_RAM__ use ......................................................................
intel/broadwell: Replace some __PRE_RAM__ use
Guards are required due to different PCI accessor signatures.
Change-Id: I60e87f16a48565917f6ee9d05cc59d2b9373270c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/broadwell/pch.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/35381/1
diff --git a/src/soc/intel/broadwell/pch.c b/src/soc/intel/broadwell/pch.c index e555588..e6c2319 100644 --- a/src/soc/intel/broadwell/pch.c +++ b/src/soc/intel/broadwell/pch.c @@ -73,7 +73,7 @@ return SPIBAR32(SPIBAR_FDOD); }
-#ifndef __PRE_RAM__ +#ifndef __SIMPLE_DEVICE__
/* Put device in D3Hot Power State */ static void pch_enable_d3hot(struct device *dev)
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35381 )
Change subject: intel/broadwell: Replace some __PRE_RAM__ use ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35381 )
Change subject: intel/broadwell: Replace some __PRE_RAM__ use ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35381 )
Change subject: intel/broadwell: Replace some __PRE_RAM__ use ......................................................................
intel/broadwell: Replace some __PRE_RAM__ use
Guards are required due to different PCI accessor signatures.
Change-Id: I60e87f16a48565917f6ee9d05cc59d2b9373270c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35381 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/pch.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/pch.c b/src/soc/intel/broadwell/pch.c index e555588..e6c2319 100644 --- a/src/soc/intel/broadwell/pch.c +++ b/src/soc/intel/broadwell/pch.c @@ -73,7 +73,7 @@ return SPIBAR32(SPIBAR_FDOD); }
-#ifndef __PRE_RAM__ +#ifndef __SIMPLE_DEVICE__
/* Put device in D3Hot Power State */ static void pch_enable_d3hot(struct device *dev)
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)