Change in coreboot[master]: mb/google/hatch: Allow variants to not necessarily be laptops
Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
mb/google/hatch: Allow variants to not necessarily be laptops
In some cases Hatch variants are not laptop form-factors such as Puff. Ensure that the base configuration does not assume the form factor and allow variants to elect their intended use-case.
BUG=b:152951181 BRANCH=none TEST=none
Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/40252/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 04790e0..9f09bfa 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -26,6 +26,9 @@ select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE
+config BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + def_bool n + if BOARD_GOOGLE_BASEBOARD_HATCH
config CHROMEOS @@ -134,8 +137,13 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN - # FIXME: allow kconfig to select on a subset of boards only - select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_PUFF select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH + +if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + +config VBOOT + select VBOOT_EARLY_EC_SYNC + +endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 454561b..ac64a9e 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -3,38 +3,45 @@ config BOARD_GOOGLE_AKEMI bool "-> Akemi" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_DRATINI bool "-> Dratini" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_32768
config BOARD_GOOGLE_JINLON bool "-> Jinlon" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select DRIVERS_GFX_GENERIC
config BOARD_GOOGLE_KOHAKU bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_KINDRED bool "-> Kindred" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_COMMON_MMC_OVERRIDE
config BOARD_GOOGLE_HELIOS bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -42,11 +49,13 @@ config BOARD_GOOGLE_MUSHU bool "-> Mushu" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_PALKIA bool "-> Palkia" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -54,6 +63,7 @@ config BOARD_GOOGLE_NIGHTFURY bool "-> Nightfury" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_PUFF @@ -67,6 +77,7 @@ config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -74,9 +85,11 @@ config BOARD_GOOGLE_STRYKE bool "-> Stryke" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_SUSHI bool "-> Sushi" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 147: select VBOOT_EARLY_EC_SYNC instead of the if... endif you could also just change the above to select VBOOT_EARLY_EC_SYNC if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 25: select SYSTEM_TYPE_LAPTOP It might be worth gating this too.
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 140: VBOOT_LID_SWITCH This probably should be gated by BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP.
Hello Sam McNally, build bot (Jenkins), Martin Roth, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40252
to look at the new patch set (#2).
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
mb/google/hatch: Allow variants to not necessarily be laptops
In some cases Hatch variants are not laptop form-factors such as Puff. Ensure that the base configuration does not assume the form factor and allow variants to elect their intended use-case.
BUG=b:152951181 BRANCH=none TEST=none
Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/40252/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 25: select SYSTEM_TYPE_LAPTOP
It might be worth gating this too.
yep fair enough, that would change the behavior of the FACP table construction in the ASL. Can you verify the kernel is happy with the implications? N.B., acpi_create_fadt()
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 140: VBOOT_LID_SWITCH
This probably should be gated by BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP.
Done. Just note the verstage implication here is that: if (CONFIG(VBOOT_LID_SWITCH) && !get_lid_switch()) ctx->flags |= VB2_CONTEXT_NOFAIL_BOOT;
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 147: select VBOOT_EARLY_EC_SYNC
instead of the if... endif you could also just change the above to […]
I guess we will be gating more here hence the structure is more generalised.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... PS2, Line 146: VBOOT_EARLY_EC_SYNC I get LID_SWITCH, but it is not immediately clear to me why VBOOT_EARLY_EC_SYNC is restricted to only for laptop form factors. Can you add a quick comment here or in the commit message?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... PS2, Line 146: VBOOT_EARLY_EC_SYNC
I get LID_SWITCH, but it is not immediately clear to me why VBOOT_EARLY_EC_SYNC is restricted to onl […]
The issue is that early ec sync needs to be disabled for efs2 to function correctly, see commit 6daa8c3ba5f from the FIXME line. The relationship is that desktops don't have a battery.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... PS2, Line 146: VBOOT_EARLY_EC_SYNC
The issue is that early ec sync needs to be disabled for efs2 to function correctly, see commit 6daa […]
Thanks for the info. The commit message for commit 6daa8c3ba5f says: "Early ec sync needs to be disabled for EFS2 to function." But it does not provide enough context to understand whether VEES should be enabled for all LAPTOPs or just for all !PUFF, nor whether this is a temporary workaround, or the final solution.
Can you please add a bit more detailed comment here and/or in the commit message to explain the linkage?
Hello Shelley Chen, Sam McNally, build bot (Jenkins), Furquan Shaikh, Martin Roth, Stefan Reinauer, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40252
to look at the new patch set (#3).
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
mb/google/hatch: Allow variants to not necessarily be laptops
In some cases Hatch variants are not laptop form-factors such as Puff. Ensure that the base configuration does not assume the form factor and allow variants to elect their intended use-case.
Note that the The issue is that early ec sync needs to be disabled for EFS2 to function correctly, see commit 6daa8c3ba5f from the FIXME line. The relationship is that desktops do not have a battery.
BUG=b:152951181 BRANCH=none TEST=none
Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/40252/3
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
I updated the commit msg. Disabling early ec sync is simply just a requirement of efs2 enablement, there isn't much else to it as far as I am aware. The other boards have already shipped so this doesn't apply to them hence the !puff.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 3: Code-Review+2
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3:
Patch Set 2:
(1 comment)
I updated the commit msg. Disabling early ec sync is simply just a requirement of efs2 enablement, there isn't much else to it as far as I am aware. The other boards have already shipped so this doesn't apply to them hence the !puff.
Thanks.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG@14 PS3, Line 14: the The double "the"
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... PS3, Line 29: select SYSTEM_TYPE_LAPTOP Maybe select BOARD_GOOGLE_BASEBOARD_HATCH here, and drop it from most entries in Kconfig.name?
Hello Shelley Chen, Sam McNally, build bot (Jenkins), Daniel Kurtz, Furquan Shaikh, Martin Roth, Stefan Reinauer, Tim Wawrzynczak, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40252
to look at the new patch set (#4).
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
mb/google/hatch: Allow variants to not necessarily be laptops
In some cases Hatch variants are not laptop form-factors such as Puff. Ensure that the base configuration does not assume the form factor and allow variants to elect their intended use-case.
Note that the issue is that early ec sync needs to be disabled for EFS2 to function correctly, see commit 6daa8c3ba5f from the FIXME line. The relationship is that desktops do not have a battery.
BUG=b:152951181 BRANCH=none TEST=none
Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/40252/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG@14 PS3, Line 14: the The
double "the"
Done
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40252/3//COMMIT_MSG@14 PS3, Line 14: the The
double "the"
Done
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... PS3, Line 29: select SYSTEM_TYPE_LAPTOP
Maybe select BOARD_GOOGLE_BASEBOARD_HATCH here, and drop it from most entries in Kconfig. […]
I could do that however I want to give myself some room to maneuver here until the requirements are clarified. I'll follow up with a change if that seems like a reasonable direction as that seems like a good idea to me.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/3/src/mainboard/google/hatch/... PS3, Line 29: select SYSTEM_TYPE_LAPTOP
I could do that however I want to give myself some room to maneuver here until the requirements are […]
Ack
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
mb/google/hatch: Allow variants to not necessarily be laptops
In some cases Hatch variants are not laptop form-factors such as Puff. Ensure that the base configuration does not assume the form factor and allow variants to elect their intended use-case.
Note that the issue is that early ec sync needs to be disabled for EFS2 to function correctly, see commit 6daa8c3ba5f from the FIXME line. The relationship is that desktops do not have a battery.
BUG=b:152951181 BRANCH=none TEST=none
Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40252 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Daniel Kurtz djkurtz@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 25 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Daniel Kurtz: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 04790e0..ff3f6a4 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -22,10 +22,13 @@ select MAINBOARD_HAS_TPM2 select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE - select SYSTEM_TYPE_LAPTOP select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE
+config BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + select SYSTEM_TYPE_LAPTOP + def_bool n + if BOARD_GOOGLE_BASEBOARD_HATCH
config CHROMEOS @@ -134,8 +137,13 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN - # FIXME: allow kconfig to select on a subset of boards only - select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_PUFF - select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH + +if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP + +config VBOOT + select VBOOT_EARLY_EC_SYNC + select VBOOT_LID_SWITCH + +endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index 454561b..ac64a9e 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -3,38 +3,45 @@ config BOARD_GOOGLE_AKEMI bool "-> Akemi" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_DRATINI bool "-> Dratini" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_HATCH bool "-> Hatch" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_32768
config BOARD_GOOGLE_JINLON bool "-> Jinlon" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select DRIVERS_GFX_GENERIC
config BOARD_GOOGLE_KOHAKU bool "-> Kohaku" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_KINDRED bool "-> Kindred" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_COMMON_MMC_OVERRIDE
config BOARD_GOOGLE_HELIOS bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -42,11 +49,13 @@ config BOARD_GOOGLE_MUSHU bool "-> Mushu" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_PALKIA bool "-> Palkia" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -54,6 +63,7 @@ config BOARD_GOOGLE_NIGHTFURY bool "-> Nightfury" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_PUFF @@ -67,6 +77,7 @@ config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384 select CHROMEOS_DSM_CALIB select DRIVERS_I2C_RT1011 @@ -74,9 +85,11 @@ config BOARD_GOOGLE_STRYKE bool "-> Stryke" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
config BOARD_GOOGLE_SUSHI bool "-> Sushi" select BOARD_GOOGLE_BASEBOARD_HATCH + select BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP select BOARD_ROMSIZE_KB_16384
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2195 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2194 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2193
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Daniel Kurtz (Code Review)
-
Edward O'Callaghan (Code Review)
-
Sam McNally (Code Review)
-
Shelley Chen (Code Review)
-
Stefan Reinauer (Code Review)