Change in coreboot[master]: src: Remove unused 'include <timestamp.h>

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

27 Aug 2019 27 Aug '19

4:05 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h> ......................................................................

src: Remove unused 'include <timestamp.h>

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/eventlog.c M src/include/bootblock_common.h M src/soc/qualcomm/sdm845/aop_load_reset.c 3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/1

diff --git a/src/drivers/amd/agesa/eventlog.c b/src/drivers/amd/agesa/eventlog.c index 887da30..a5c0393 100644 --- a/src/drivers/amd/agesa/eventlog.c +++ b/src/drivers/amd/agesa/eventlog.c @@ -16,7 +16,6 @@ #include <console/console.h> #include <stdint.h> #include <string.h> -#include <timestamp.h>

#include <northbridge/amd/agesa/state_machine.h> #include <northbridge/amd/agesa/BiosCallOuts.h> diff --git a/src/include/bootblock_common.h b/src/include/bootblock_common.h index 1081f27..e31ea41 100644 --- a/src/include/bootblock_common.h +++ b/src/include/bootblock_common.h @@ -18,7 +18,6 @@

#include <arch/cpu.h> #include <main_decl.h> -#include <timestamp.h> #include <types.h>

/* diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c index 02217f9..8479856 100644 --- a/src/soc/qualcomm/sdm845/aop_load_reset.c +++ b/src/soc/qualcomm/sdm845/aop_load_reset.c @@ -18,7 +18,6 @@ #include <cbfs.h> #include <halt.h> #include <console/console.h> -#include <timestamp.h> #include <soc/mmu.h> #include <soc/aop.h> #include <soc/clock.h>

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

HAOUAS Elyes (Code Review)

27 Aug 27 Aug

4:06 p.m.

New subject: Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>' ......................................................................

src: Remove unused 'include <timestamp.h>'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/2

HAOUAS Elyes (Code Review)

4:09 p.m.

New subject: Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#3).

Change subject: src: Remove unused 'include <timestamp.h>' ......................................................................

src: Remove unused 'include <timestamp.h>'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/3

Nico Huber (Code Review)

23 Nov 23 Nov

12:12 p.m.

New subject: Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>' ......................................................................

Patch Set 7:

(1 comment)

No idea what the intention was wrt. `include/timestamp.h` vs the commonlib one. I'd say the indirect include is ok?

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG@7 PS7, Line 7: src: Remove unused 'include <timestamp.h>' Also `replace`? and it's not unused if you need to replace it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 23 Nov 2019 11:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:23 p.m.

New subject: Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>' ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG@7 PS7, Line 7: src: Remove unused 'include <timestamp.h>'

...

Also `replace`? and it's not unused if you need to replace it.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 23 Nov 2019 11:23:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:23 p.m.

New subject: Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#8).

Change subject: src: Remove or replace not used 'include <timestamp.h>' ......................................................................

src: Remove or replace not used 'include <timestamp.h>'

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kyösti Mälkki (Code Review)

2 Dec 2 Dec

12:38 p.m.

New subject: Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove or replace not used 'include <timestamp.h>' ......................................................................

Patch Set 8:

We approved <timestamp.h> as an indirect include for <commonlib/timestamp_serialized.h>. Nobody includes the latter directly while everybody uses it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Dec 2019 11:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:47 p.m.

New subject: Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#9).

Change subject: src: Remove or replace not used 'include <timestamp.h>' ......................................................................

src: Remove or replace not used 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sdm845/aop_load_reset.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kyösti Mälkki (Code Review)

12:49 p.m.

New subject: Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove or replace not used 'include <timestamp.h>' ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG@7 PS9, Line 7: src: Remove or replace not used 'include <timestamp.h>' no replacements

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Dec 2019 11:49:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:04 p.m.

New subject: Change in coreboot[master]: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#10).

Change subject: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>' ......................................................................

soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sdm845/aop_load_reset.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:05 p.m.

New subject: Change in coreboot[master]: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>' ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG@7 PS9, Line 7: src: Remove or replace not used 'include <timestamp.h>'

...

no replacements

Oops :)

Thank you.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 02 Dec 2019 13:05:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

19 Dec 19 Dec

4:51 a.m.

New subject: Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Kyösti Mälkki has uploaded a new patch set (#13) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>' ......................................................................

soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/qualcomm/sdm845/aop_load_reset.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 13 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Aaron Durbin (Code Review)

6:16 a.m.

New subject: Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>' ......................................................................

Patch Set 13: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 13 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Dec 2019 05:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

6:18 a.m.

New subject: Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>' ......................................................................

soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35123 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/qualcomm/sdm845/aop_load_reset.c 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c index 317c4fe..782c83a 100644 --- a/src/soc/qualcomm/sdm845/aop_load_reset.c +++ b/src/soc/qualcomm/sdm845/aop_load_reset.c @@ -16,7 +16,6 @@ #include <arch/cache.h> #include <cbfs.h> #include <console/console.h> -#include <timestamp.h> #include <soc/mmu.h> #include <soc/aop.h> #include <soc/clock.h>

-- To view, visit https://review.coreboot.org/c/coreboot/+/35123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1740

days inactive

1854

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

Aaron Durbin (Code Review)
HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Nico Huber (Code Review)