Change in coreboot[master]: src: Remove unused 'include <timestamp.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>
......................................................................

src: Remove unused 'include <timestamp.h>

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/amd/agesa/eventlog.c
M src/include/bootblock_common.h
M src/soc/qualcomm/sdm845/aop_load_reset.c
3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/1

diff --git a/src/drivers/amd/agesa/eventlog.c b/src/drivers/amd/agesa/eventlog.c
index 887da30..a5c0393 100644
--- a/src/drivers/amd/agesa/eventlog.c
+++ b/src/drivers/amd/agesa/eventlog.c
@@ -16,7 +16,6 @@
 #include <console/console.h>
 #include <stdint.h>
 #include <string.h>
-#include <timestamp.h>

#include <northbridge/amd/agesa/state_machine.h>
 #include <northbridge/amd/agesa/BiosCallOuts.h>
diff --git a/src/include/bootblock_common.h b/src/include/bootblock_common.h
index 1081f27..e31ea41 100644
--- a/src/include/bootblock_common.h
+++ b/src/include/bootblock_common.h
@@ -18,7 +18,6 @@

#include <arch/cpu.h>
 #include <main_decl.h>
-#include <timestamp.h>
 #include <types.h>

/*
diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c
index 02217f9..8479856 100644
--- a/src/soc/qualcomm/sdm845/aop_load_reset.c
+++ b/src/soc/qualcomm/sdm845/aop_load_reset.c
@@ -18,7 +18,6 @@
 #include <cbfs.h>
 #include <halt.h>
 #include <console/console.h>
-#include <timestamp.h>
 #include <soc/mmu.h>
 #include <soc/aop.h>
 #include <soc/clock.h>

Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>'
......................................................................

src: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/amd/agesa/eventlog.c
M src/include/bootblock_common.h
M src/soc/qualcomm/sdm845/aop_load_reset.c
3 files changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/2

Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#3).

Change subject: src: Remove unused 'include <timestamp.h>'
......................................................................

src: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/amd/agesa/eventlog.c
M src/include/bootblock_common.h
M src/soc/qualcomm/sdm845/aop_load_reset.c
3 files changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/3

Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>'
......................................................................

Patch Set 7:

(1 comment)

No idea what the intention was wrt. `include/timestamp.h` vs the commonlib
one. I'd say the indirect include is ok?

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG@7 
PS7, Line 7: src: Remove unused 'include <timestamp.h>'
Also `replace`? and it's not unused if you need to replace it.

Change in coreboot[master]: src: Remove unused 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove unused 'include <timestamp.h>'
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/7//COMMIT_MSG@7 
PS7, Line 7: src: Remove unused 'include <timestamp.h>'
> Also `replace`? and it's not unused if you need to replace it.

Done

Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#8).

Change subject: src: Remove or replace not used 'include <timestamp.h>'
......................................................................

src: Remove or replace not used 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/amd/agesa/eventlog.c
M src/include/bootblock_common.h
M src/soc/qualcomm/sdm845/aop_load_reset.c
3 files changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/8

Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove or replace not used 'include <timestamp.h>'
......................................................................

Patch Set 8:

We approved <timestamp.h> as an indirect include for <commonlib/timestamp_serialized.h>. Nobody includes the latter directly while everybody uses it.

Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#9).

Change subject: src: Remove or replace not used 'include <timestamp.h>'
......................................................................

src: Remove or replace not used 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/soc/qualcomm/sdm845/aop_load_reset.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/9

Change in coreboot[master]: src: Remove or replace not used 'include <timestamp.h>'

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: src: Remove or replace not used 'include <timestamp.h>'
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG@7 
PS9, Line 7: src: Remove or replace not used 'include <timestamp.h>'
no replacements

Change in coreboot[master]: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Angel Pons, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35123

to look at the new patch set (#10).

Change subject: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'
......................................................................

soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/soc/qualcomm/sdm845/aop_load_reset.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/10

Change in coreboot[master]: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove used 'include <timestamp.h>'
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35123/9//COMMIT_MSG@7 
PS9, Line 7: src: Remove or replace not used 'include <timestamp.h>'
> no replacements

Oops :)

Thank you.

Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded a new patch set (#13) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'
......................................................................

soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
---
M src/soc/qualcomm/sdm845/aop_load_reset.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/35123/13

Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'
......................................................................

Patch Set 13: Code-Review+2

Change in coreboot[master]: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35123 )

Change subject: soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'
......................................................................

soc/qualcomm/sdm845: Remove unused 'include <timestamp.h>'

Change-Id: I9b91184ee1daf4dd40f17984ef2a30756e845906
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35123
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
---
M src/soc/qualcomm/sdm845/aop_load_reset.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved

diff --git a/src/soc/qualcomm/sdm845/aop_load_reset.c b/src/soc/qualcomm/sdm845/aop_load_reset.c
index 317c4fe..782c83a 100644
--- a/src/soc/qualcomm/sdm845/aop_load_reset.c
+++ b/src/soc/qualcomm/sdm845/aop_load_reset.c
@@ -16,7 +16,6 @@
 #include <arch/cache.h>
 #include <cbfs.h>
 #include <console/console.h>
-#include <timestamp.h>
 #include <soc/mmu.h>
 #include <soc/aop.h>
 #include <soc/clock.h>