Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32302
Change subject: mb/siemens/mc_apl4: Remove usage uf external RTC ......................................................................
mb/siemens/mc_apl4: Remove usage uf external RTC
The external RTC was removed on the mainboard as it is not needed. Remove the usage of the driver for RX6110SA as well.
Change-Id: Ia476e58c0b0f343d4e9e4fa6039bf82b194a87d3 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb 2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32302/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig index 060d695..1ee72bb 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig @@ -5,7 +5,6 @@ def_bool y select DRIVER_INTEL_I210 select APL_SET_MIN_CLOCK_RATIO - select DRIVERS_I2C_RX6110SA select MAINBOARD_HAS_TPM2 select MAINBOARD_HAS_LPC_TPM select TPM_ON_FAST_SPI diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index 53a3394..03f6c43 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -75,21 +75,7 @@ device pci 17.0 on end # - I2C 4 device pci 17.1 on end # - I2C 5 device pci 17.2 on end # - I2C 6 - device pci 17.3 on # - I2C 7 - # Enable external RTC chip - chip drivers/i2c/rx6110sa - register "pmon_sampling" = "PMON_SAMPL_256_MS" - register "bks_on" = "0" - register "bks_off" = "1" - register "iocut_en" = "1" - register "set_user_date" = "1" - register "user_year" = "04" - register "user_month" = "07" - register "user_day" = "01" - register "user_weekday" = "4" - device i2c 0x32 on end # RTC RX6110 SA - end - end + device pci 17.3 on end # - I2C 7 device pci 18.0 on end # - UART 0 device pci 18.1 on end # - UART 1 device pci 18.2 on end # - UART 2
Werner Zeh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32302 )
Change subject: mb/siemens/mc_apl4: Remove usage of external RTC ......................................................................
mb/siemens/mc_apl4: Remove usage of external RTC
The external RTC was removed on the mainboard as it is not needed. Remove the usage of the driver for RX6110SA as well.
Change-Id: Ia476e58c0b0f343d4e9e4fa6039bf82b194a87d3 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb 2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/32302/2
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32302 )
Change subject: mb/siemens/mc_apl4: Remove usage of external RTC ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32302 )
Change subject: mb/siemens/mc_apl4: Remove usage of external RTC ......................................................................
Patch Set 2: Code-Review+2
Uwe Poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32302 )
Change subject: mb/siemens/mc_apl4: Remove usage of external RTC ......................................................................
Patch Set 2: Code-Review+1
Werner Zeh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32302 )
Change subject: mb/siemens/mc_apl4: Remove usage of external RTC ......................................................................
mb/siemens/mc_apl4: Remove usage of external RTC
The external RTC was removed on the mainboard as it is not needed. Remove the usage of the driver for RX6110SA as well.
Change-Id: Ia476e58c0b0f343d4e9e4fa6039bf82b194a87d3 Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32302 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Uwe Poeche uwe.poeche@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb 2 files changed, 1 insertion(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Mario Scheithauer: Looks good to me, approved Uwe Poeche: Looks good to me, but someone else must approve
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig index 060d695..1ee72bb 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig @@ -5,7 +5,6 @@ def_bool y select DRIVER_INTEL_I210 select APL_SET_MIN_CLOCK_RATIO - select DRIVERS_I2C_RX6110SA select MAINBOARD_HAS_TPM2 select MAINBOARD_HAS_LPC_TPM select TPM_ON_FAST_SPI diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index 53a3394..50207e0 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -75,21 +75,7 @@ device pci 17.0 on end # - I2C 4 device pci 17.1 on end # - I2C 5 device pci 17.2 on end # - I2C 6 - device pci 17.3 on # - I2C 7 - # Enable external RTC chip - chip drivers/i2c/rx6110sa - register "pmon_sampling" = "PMON_SAMPL_256_MS" - register "bks_on" = "0" - register "bks_off" = "1" - register "iocut_en" = "1" - register "set_user_date" = "1" - register "user_year" = "04" - register "user_month" = "07" - register "user_day" = "01" - register "user_weekday" = "4" - device i2c 0x32 on end # RTC RX6110 SA - end - end + device pci 17.3 on end # - I2C 7 device pci 18.0 on end # - UART 0 device pci 18.1 on end # - UART 1 device pci 18.2 on end # - UART 2
-
Kyösti Mälkki (Code Review) -
Mario Scheithauer (Code Review)
-
Uwe Poeche (Code Review)
-
Werner Zeh (Code Review)