Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49077 )
Change subject: mb/clevo/l140cu: Move FSP-M config hook to mainboard level ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/r... File src/mainboard/clevo/cml-u/romstage.c:
https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/r... PS4, Line 6: ry_init_params(FSPM_UPD *memupd) : { : variant_configure_fspm(memupd); : } : do we really want to create this redirection hell before it's really needed? as long as we have no code that runs for all variants in cml-u/romstage.c it doesn't hurt to have a romstage.c for each variant