Attention is currently required from: Nico Huber, Paul Menzel, Julius Werner.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57199 )
Change subject: drivers/intel/fsp2_0: Make framebuffer orientation to be configurable
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File src/drivers/intel/fsp2_0/graphics.c:
https://review.coreboot.org/c/coreboot/+/57199/comment/9f7e31fe_627876dc
PS1, Line 103: enum lb_fb_orientation __weak fsp_get_framebuffer_orientation(void)
There's a call to fb_add_framebuffer_info_ex() above. I have no idea why it couldn't be done inside that function or below.
Thanks, it seems good to place the orientation override. Please see a new patch - CB:57327.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57199
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If51d2698d5fdf651183a908717076c8a14605997
Gerrit-Change-Number: 57199
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 02 Sep 2021 02:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: shkim
sh_.kim@samsung.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment