[XS] Change in coreboot[main]: [DNM] cpu/x86/64bit/mode_switch2.S: Support runtime page tables - coreboot-gerrit

10 Jan 2024


      Attention is currently required from: Jérémy Compostella, Patrick Rudolph.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79863?usp=email )
Change subject: [DNM] cpu/x86/64bit/mode_switch2.S: Support runtime page tables
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/64bit/mode_switch2.S:
https://review.coreboot.org/c/coreboot/+/79863/comment/23eabdbd_f4772f01 :
PS1, Line 22: page_tables
...
that's not a global variable
It compiles, still need to test. If it does work, my guess is that the linker can find the symbol. To the linker, can symbols actually be private?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic964038fd4dd810015e6a355a171e49db648c8fe
Gerrit-Change-Number: 79863
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 10 Jan 2024 06:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment