Attention is currently required from: Julius Werner, Yu-Ping Wu.
Hello Julius Werner, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75521?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: vboot: Drop argument to select slot from `vb2ex_ec_protect()` ......................................................................
vboot: Drop argument to select slot from `vb2ex_ec_protect()`
vboot code changes has eliminated the redundant call to WP the EC-RO region as protecting RW flash implies protecting both RO and RW flash, so the call to protect RO is redundant. google/rex is currently takes about 17 ms to lock down the EC.
Along with vboot changes, this patch drops argument to choose between RO and RW slot to protect while calling into `vb2ex_ec_protect()`. It ensures vb2ex_ec_protect() is explicitly meant for protecting RW regions.
Additionally, update vboot submodule to upstream main to avoid the compilation error.
Updating from commit id 35f50c3154e5: Fix build error when compiling without -DNDEBUG to commit id 034907b279c9db: vboot_reference: eliminate redundant call to write protect EC-RO
Change-Id: I2974f0cb43ba800c2aaeac4876ebaa052b5ee793 Signed-off-by: Subrata Banik subratabanik@google.com --- M 3rdparty/vboot M src/security/vboot/ec_sync.c 2 files changed, 5 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/75521/4