Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 185 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 343b30b..9a2e373 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -50,6 +50,7 @@ default "trembyle" if BOARD_GOOGLE_TREMBYLE default "dalboz" if BOARD_GOOGLE_DALBOZ default "berknip" if BOARD_GOOGLE_BERKNIP + default "vilboz" if BOARD_GOOGLE_VILBOZ
config MAINBOARD_PART_NUMBER string @@ -58,6 +59,7 @@ default "Trembyle" if BOARD_GOOGLE_TREMBYLE default "Dalboz" if BOARD_GOOGLE_DALBOZ default "Berknip" if BOARD_GOOGLE_BERKNIP + default "Vilboz" if BOARD_GOOGLE_VILBOZ
config DEVICETREE string diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 065f60c..2f721d4 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -4,6 +4,10 @@ bool "-> Dalboz" select BOARD_GOOGLE_BASEBOARD_DALBOZ
+config BOARD_GOOGLE_VILBOZ + bool "-> Vilboz" + select BOARD_GOOGLE_BASEBOARD_DALBOZ + config BOARD_GOOGLE_EZKINIL bool "-> Ezkinil" select BOARD_GOOGLE_BASEBOARD_TREMBYLE diff --git a/src/mainboard/google/zork/variants/vilboz/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/Makefile.inc new file mode 100644 index 0000000..dc1e411 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/Makefile.inc @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./spd + +ramstage-y += variant.c diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..8177a9d --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/sleep.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h b/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h b/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h b/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb new file mode 100644 index 0000000..99e51ec --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -0,0 +1,99 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "6000" #mw + register "fast_ppt_limit" = "9000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "2500" #second + register "sustained_power_limit" = "4800" #mw + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 18, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 57, /* 2.31 to 0 */ + }" + + # I2C3 for H1 + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 42, /* 1.26v to 0 */ + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on end # USB 3.1 + end + device pci 14.3 on # - D14F3 bridge + chip ec/google/chromeec + device pnp 0c09.0 on + chip ec/google/chromeec/i2c_tunnel + register "uid" = "1" + register "remote_bus" = "8" + device generic 0.0 on + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""RT1015 Tweeter Left Speaker Amp"" + register "uid" = "0" + register "name" = ""TL"" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""RT1015 Tweeter Right Speaker Amp"" + register "uid" = "1" + register "name" = ""TR"" + device i2c 29 on end + end + end + end + end + end + end + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" + register "generic.reset_delay_ms" = "120" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "wake" = "7" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end +end # chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc new file mode 100644 index 0000000..4494b98 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc @@ -0,0 +1,11 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +# Ordered List of APCB entries, up to 16. +# Entries should match this pattern {NAME}_x{1,2} +# There should be a matching SPD hex file in SPD_SOURCES_DIR +# matching the pattern {NAME}.spd.hex +# The _x{1,2} suffix denotes single or dual channel +# TODO: Remove channel suffix when b:141434940 is fixed +# Alternatively, generated APCBs stored at +# CONFIG_APCB_BLOB_DIR/APCB_{NAME}.bin can be included. +APCB_SOURCES = empty diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c new file mode 100644 index 0000000..9a12413 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/variant.c @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/variants.h> +#include <console/console.h> +#include <device/device.h> +#include <drivers/i2c/generic/chip.h> +#include <soc/pci_devs.h> +#include <ec/google/chromeec/ec.h> +#include <ec/google/chromeec/i2c_tunnel/chip.h> +#include <string.h> + +#define EC_PNP_ID 0x0c09 + +extern struct chip_operations ec_google_chromeec_i2c_tunnel_ops; + +static const picasso_fsp_ddi_descriptor hdmi_ddi_descriptors[] = { + { // DDI0, DP0, eDP + .connector_type = EDP, + .aux_index = AUX1, + .hdp_index = HDP1 + }, + { // DDI1, DP1, DB OPT2 USB-C1 / DB OPT3 MST hub + .connector_type = HDMI, + .aux_index = AUX2, + .hdp_index = HDP2 + }, + { // DDI2, DP3, USB-C0 + .connector_type = DP, + .aux_index = AUX4, + .hdp_index = HDP4, + } +}; + +void variant_get_pcie_ddi_descriptors(const picasso_fsp_pcie_descriptor **pcie_descs, + size_t *pcie_num, + const picasso_fsp_ddi_descriptor **ddi_descs, + size_t *ddi_num) +{ + *pcie_descs = baseboard_get_pcie_descriptors(pcie_num); + + *ddi_descs = &hdmi_ddi_descriptors[0]; + *ddi_num = ARRAY_SIZE(hdmi_ddi_descriptors); +}
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 4: #include <console/console.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 5: #include <device/device.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 6: #include <drivers/i2c/generic/chip.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 8: #include <ec/google/chromeec/ec.h> : #include <ec/google/chromeec/i2c_tunnel/chip.h> : #include <string.h> Not required.
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 12: #define EC_PNP_ID 0x0c09 : : extern struct chip_operations ec_google_chromeec_i2c_tunnel_ops; Not required.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 41: &hdmi_ddi_descriptors[0] hdmi_ddi_descriptors
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#2).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 177 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 4: #include <console/console.h>
Not required.
Done
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 5: #include <device/device.h>
Not required.
Done
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 6: #include <drivers/i2c/generic/chip.h>
Not required.
Done
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 8: #include <ec/google/chromeec/ec.h> : #include <ec/google/chromeec/i2c_tunnel/chip.h> : #include <string.h>
Not required.
Done
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 12: #define EC_PNP_ID 0x0c09 : : extern struct chip_operations ec_google_chromeec_i2c_tunnel_ops;
Not required.
Done
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 41: &hdmi_ddi_descriptors[0]
hdmi_ddi_descriptors
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/1/src/mainboard/google/zork/v... PS1, Line 41: &hdmi_ddi_descriptors[0]
Done
Dear Angel,
I thinks that is good. So keep it.
Thanks and best regards
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2: Code-Review+1
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso nit: new line after license
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Just one final change. Rest looks good.
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 6: #define EC_PNP_ID 0x0c09 This too isn't used/needed.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
nit: new line after license
Done
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 6: #define EC_PNP_ID 0x0c09
This too isn't used/needed.
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 6: #define EC_PNP_ID 0x0c09
Done
where is this done?
Hello build bot (Jenkins), Raul Rangel, Patrick Georgi, Furquan Shaikh, Martin Roth, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#3).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 175 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 3: Code-Review+1
Hello build bot (Jenkins), Raul Rangel, Patrick Georgi, Furquan Shaikh, Martin Roth, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#4).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341, b:157709412 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 175 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
Done
This seems to be not addressed yet.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
This seems to be not addressed yet.
Sorry I am confuse, what the problem in here? Thanks a lot!
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@4 PS4, Line 4: Peichao Li Above it says *Wang* instead of *Li*.
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@13 PS4, Line 13: peichao.wang Please use *Peichao Wang*.
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... PS4, Line 12: register "slow_ppt_limit" = "6000" #mw : register "fast_ppt_limit" = "9000" #mw : register "slow_ppt_time_constant" = "5" #second : register "stapm_time_constant" = "2500" #second : register "sustained_power_limit" = "4800" #mw Please add a space after the comment characters, and use SI notations: mW.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
Sorry I am confuse, what the problem in here? Thanks a lot!
Add a blank line between lines 1 and 2
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#5).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/5
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#6).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/6
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@4 PS4, Line 4: Peichao Li
Above it says *Wang* instead of *Li*.
Done
https://review.coreboot.org/c/coreboot/+/41801/4//COMMIT_MSG@13 PS4, Line 13: peichao.wang
Please use *Peichao Wang*.
Done
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/2/src/mainboard/google/zork/v... PS2, Line 2: chip soc/amd/picasso
Add a blank line between lines 1 and 2
Done
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/4/src/mainboard/google/zork/v... PS4, Line 12: register "slow_ppt_limit" = "6000" #mw : register "fast_ppt_limit" = "9000" #mw : register "slow_ppt_time_constant" = "5" #second : register "stapm_time_constant" = "2500" #second : register "sustained_power_limit" = "4800" #mw
Please add a space after the comment characters, and use SI notations: mW.
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 6: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 13: mw nit: use mW (capital W)
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 14: mw mW
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 17: mw mW
Hello build bot (Jenkins), Raul Rangel, Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won, Paul Fagerburg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41801
to look at the new patch set (#7).
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41801/7
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 7: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 13: mw
nit: use mW (capital W)
Done
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 14: mw
mW
Done
https://review.coreboot.org/c/coreboot/+/41801/6/src/mainboard/google/zork/v... PS6, Line 17: mw
mW
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 7:
Patch Set 7: Code-Review+2
(3 comments)
Many thanks Paul, I had studied more.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 7: Code-Review+1
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 7: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
mb/google/zork: create new variant for Vilboz
BUG=b:157499341 BRANCH=NONE TEST=FW_NAME="vilboz" emerge-zork coreboot
Signed-off-by: peichao.wang peichao.wang@bitland.corp-partner.google.com Change-Id: I28ab3edb130fc7bf8b786141bc088166052d4868 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41801 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/Kconfig M src/mainboard/google/zork/Kconfig.name A src/mainboard/google/zork/variants/vilboz/Makefile.inc A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl A src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl A src/mainboard/google/zork/variants/vilboz/include/variant/ec.h A src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h A src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h A src/mainboard/google/zork/variants/vilboz/overridetree.cb A src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc A src/mainboard/google/zork/variants/vilboz/variant.c 13 files changed, 176 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index 343b30b..9a2e373 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -50,6 +50,7 @@ default "trembyle" if BOARD_GOOGLE_TREMBYLE default "dalboz" if BOARD_GOOGLE_DALBOZ default "berknip" if BOARD_GOOGLE_BERKNIP + default "vilboz" if BOARD_GOOGLE_VILBOZ
config MAINBOARD_PART_NUMBER string @@ -58,6 +59,7 @@ default "Trembyle" if BOARD_GOOGLE_TREMBYLE default "Dalboz" if BOARD_GOOGLE_DALBOZ default "Berknip" if BOARD_GOOGLE_BERKNIP + default "Vilboz" if BOARD_GOOGLE_VILBOZ
config DEVICETREE string diff --git a/src/mainboard/google/zork/Kconfig.name b/src/mainboard/google/zork/Kconfig.name index 065f60c..2f721d4 100644 --- a/src/mainboard/google/zork/Kconfig.name +++ b/src/mainboard/google/zork/Kconfig.name @@ -4,6 +4,10 @@ bool "-> Dalboz" select BOARD_GOOGLE_BASEBOARD_DALBOZ
+config BOARD_GOOGLE_VILBOZ + bool "-> Vilboz" + select BOARD_GOOGLE_BASEBOARD_DALBOZ + config BOARD_GOOGLE_EZKINIL bool "-> Ezkinil" select BOARD_GOOGLE_BASEBOARD_TREMBYLE diff --git a/src/mainboard/google/zork/variants/vilboz/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/Makefile.inc new file mode 100644 index 0000000..dc1e411 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/Makefile.inc @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./spd + +ramstage-y += variant.c diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..8177a9d --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/sleep.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/sleep.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h b/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h b/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h b/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb new file mode 100644 index 0000000..79f26f2 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "6000" # mW + register "fast_ppt_limit" = "9000" # mW + register "slow_ppt_time_constant" = "5" # second + register "stapm_time_constant" = "2500" # second + register "sustained_power_limit" = "4800" # mW + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 18, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 57, /* 2.31 to 0 */ + }" + + # I2C3 for H1 + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 42, /* 1.26v to 0 */ + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on end # USB 3.1 + end + device pci 14.3 on # - D14F3 bridge + chip ec/google/chromeec + device pnp 0c09.0 on + chip ec/google/chromeec/i2c_tunnel + register "uid" = "1" + register "remote_bus" = "8" + device generic 0.0 on + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""RT1015 Tweeter Left Speaker Amp"" + register "uid" = "0" + register "name" = ""TL"" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""RT1015 Tweeter Right Speaker Amp"" + register "uid" = "1" + register "name" = ""TR"" + device i2c 29 on end + end + end + end + end + end + end + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_140)" + register "generic.reset_delay_ms" = "120" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "wake" = "7" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" + register "generic.wake" = "7" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end +end # chip soc/amd/picasso diff --git a/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc new file mode 100644 index 0000000..4494b98 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/spd/Makefile.inc @@ -0,0 +1,11 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +# Ordered List of APCB entries, up to 16. +# Entries should match this pattern {NAME}_x{1,2} +# There should be a matching SPD hex file in SPD_SOURCES_DIR +# matching the pattern {NAME}.spd.hex +# The _x{1,2} suffix denotes single or dual channel +# TODO: Remove channel suffix when b:141434940 is fixed +# Alternatively, generated APCBs stored at +# CONFIG_APCB_BLOB_DIR/APCB_{NAME}.bin can be included. +APCB_SOURCES = empty diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c new file mode 100644 index 0000000..eb0ded9 --- /dev/null +++ b/src/mainboard/google/zork/variants/vilboz/variant.c @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/variants.h> +#include <soc/pci_devs.h> + +static const picasso_fsp_ddi_descriptor hdmi_ddi_descriptors[] = { + { // DDI0, DP0, eDP + .connector_type = EDP, + .aux_index = AUX1, + .hdp_index = HDP1 + }, + { // DDI1, DP1, DB OPT2 USB-C1 / DB OPT3 MST hub + .connector_type = HDMI, + .aux_index = AUX2, + .hdp_index = HDP2 + }, + { // DDI2, DP3, USB-C0 + .connector_type = DP, + .aux_index = AUX4, + .hdp_index = HDP4, + } +}; + +void variant_get_pcie_ddi_descriptors(const picasso_fsp_pcie_descriptor **pcie_descs, + size_t *pcie_num, + const picasso_fsp_ddi_descriptor **ddi_descs, + size_t *ddi_num) +{ + *pcie_descs = baseboard_get_pcie_descriptors(pcie_num); + + *ddi_descs = &hdmi_ddi_descriptors[0]; + *ddi_num = ARRAY_SIZE(hdmi_ddi_descriptors); +}
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41801 )
Change subject: mb/google/zork: create new variant for Vilboz ......................................................................
Patch Set 8:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4877 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4876 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4875 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4874
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Kangheui Won (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)
-
Raul Rangel (Code Review)