[XS] Change in coreboot[main]: mb/google/volteer/drobit: fix power_limits_config

[Paul Menzel (Code Review)]

Attention is currently required from: Ariel Chang, Ingo Reitz, Matt DeVillier, Nick Vaccaro, Paul Yang, Wayne3 Wang.

Paul Menzel has posted comments on this change by Ingo Reitz. ( https://review.coreboot.org/c/coreboot/+/86026?usp=email )

Change subject: mb/google/volteer/drobit: fix power_limits_config
......................................................................

Patch Set 4:

(9 comments)

Patchset:

PS4: 
How to access the Chromium issue `BUG=b:177777472`?

Commit Message:

https://review.coreboot.org/c/coreboot/+/86026/comment/fd1adec2_17132e6c?usp... :
PS4, Line 7: volteer/drobit
Add variants in between?

https://review.coreboot.org/c/coreboot/+/86026/comment/21eed1ff_674d831f?usp... :
PS4, Line 9: little power usage and very low clock speeds under load
Concrete values would be nice.

https://review.coreboot.org/c/coreboot/+/86026/comment/aaa229be_289c1d95?usp... :
PS4, Line 9: Drobit shows little power usage and very low clock speeds under load,
           : despite being at very low temperatures. It turns out that
           : power_limits_config is set to the lower end of the dptf power limit
           : ranges as opposed to baseboard and other variants. This seems to
           : prevent the device from using the intended power limits.
Commit a5761efd14a2 (mb/google/volteer/variants/drobit: Update DPTF parameters), decreased `.tdp_pl1_override` from 13 to 9. Do you know if there is another commit in some Chromium branch changes the values? I’d have thought, Google has good test coverage that they would have detected such a problem.

https://review.coreboot.org/c/coreboot/+/86026/comment/f88afac2_27574989?usp... :
PS4, Line 15: correct power usage, clock speeds temperature
It’d be great if you added the specific values.

https://review.coreboot.org/c/coreboot/+/86026/comment/74085b38_dba82488?usp... :
PS4, Line 15: temperature
It‘d be great if you could be more specific.

https://review.coreboot.org/c/coreboot/+/86026/comment/28953e5b_b4ac031d?usp... :
PS4, Line 15: speeds
Comma after *speeds*?

https://review.coreboot.org/c/coreboot/+/86026/comment/01d44531_62e68d51?usp... :
PS4, Line 15: Tested
No idea if there are different CPU models in drobit, but it’d be great if you listed yours.

https://review.coreboot.org/c/coreboot/+/86026/comment/b5f9e5db_82e024a6?usp... :
PS4, Line 16: 100% load
How do you create this load?