Change in coreboot[master]: drivers/intel/dptf: Introduce new thermal control mechanism for pch d...

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 )

Change subject: drivers/intel/dptf: Introduce new thermal control mechanism for pch device
......................................................................

Patch Set 5:

(5 comments)

Patchset:

PS5: 
Any plans to support GFC0, GFC1, GEMI, SEMI, GFCS, GFCS ?

File src/drivers/intel/dptf/dptf.c:

https://review.coreboot.org/c/coreboot/+/57096/comment/e011ef39_7f95e597 
PS5, Line 7: #include <soc/intel/common/block/include/intelblocks/pmc_ipc.h>
`#include <intelblocks/pmc_ipc.h>`

https://review.coreboot.org/c/coreboot/+/57096/comment/2751b7e3_1845009e 
PS5, Line 200: int
nit: 
`unsigned int`

https://review.coreboot.org/c/coreboot/+/57096/comment/f69c4674_878009d5 
PS5, Line 211: 	acpigen_emit_byte(RETURN_OP);
             : 	acpigen_write_package(0);
             : 	acpigen_write_package_end();
Why does this return a value? I don't see the kernel driver expecting any return value from these methods.

https://review.coreboot.org/c/coreboot/+/57096/comment/75ec90e7_763ef794 
PS5, Line 237: acpigen_pop_len
acpigen_write_device_end()