Attention is currently required from: Sean Rhodes, Subrata Banik, Dinesh Gehlot, Lean Sheng Tan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Don't hardcode ramtop offset
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File src/soc/intel/common/basecode/ramtop/ramtop.c:
https://review.coreboot.org/c/coreboot/+/74511/comment/8876ed28_b71d8ed3
PS10, Line 19: */
This still seems like valuable information. OTOH, we could also add a
check for it too, I guess. A related thought: What happens if there
is an option table but without the `ramtop_cmos_offset`? I guess that
we might want a better error message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment