Attention is currently required from: Arthur Heymans, Tarun Tuli, Subrata Banik, Paul Menzel.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64802 )
Change subject: cpu/smm_module_loader.c: Fix up CPU index locally
......................................................................
Patch Set 30:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64802/comment/06c1ea4c_1ae80c7f
PS30, Line 11: an Intel
: platform
Which one did you test with? […]
According to gerrit guidlines the 'TEST' prefix basically means that you tested it already. So I would basically write it like this to avoid confusion:
```
TODO Test: see that SMM is properly relocated on all CPUs on an Intel platform.
```
or something similar (nothing good comes to mind really)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I070bc00ae5e5bceb6c5b90ea833cc057dd41f6cc
Gerrit-Change-Number: 64802
Gerrit-PatchSet: 30
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 06 Apr 2023 12:41:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment