Change in coreboot[master]: soc/amd/picasso: Drop some Kconfig options from being user-visible

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop some Kconfig options from being user-visible
......................................................................

soc/amd/picasso: Drop some Kconfig options from being user-visible

Some of the PSP Kconfig options that are prompted to the user should
really be selected by mainboard. This change updates such options to
not make them user-visible any more.

BUG=b:154880818

Change-Id: Iaff02fb1e720e0562b740799593322e59b022212
Signed-off-by: Furquan Shaikh 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/40699/1

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index f3ad1fc..f6b94d4 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -221,7 +221,7 @@
 menu "PSP Configuration Options"

config AMDFW_OUTSIDE_CBFS
-	bool "The AMD firmware is outside CBFS"
+	bool
    default n
    help
      The AMDFW (PSP) is typically locatable in cbfs.  Select this
@@ -262,11 +262,11 @@
    depends on AMD_FWM_POSITION_INDEX = 5

config AMD_PUBKEY_FILE
-	string "AMD public Key"
+	string
    default "3rdparty/blobs/soc/amd/picasso/PSP/AmdPubKeyRV.bin"

config PSP_APCB_FILE
-	string "APCB file"
+	string
    help
      The name of the AGESA Parameter Customization Block.  This image is
      instance ID 0 in the PSP's BIOS Directory Table.
@@ -315,7 +315,7 @@
      size the flash device can erase.

config USE_PSPSCUREOS
-	bool "Include PSP SecureOS blobs in PSP build"
+	bool
    default y
    help
      Include the PspSecureOs and PspTrustlet binaries in the PSP build.
@@ -323,7 +323,7 @@
      If unsure, answer 'y'

config PSP_LOAD_MP2_FW
-	bool "Include MP2 blobs in PSP build"
+	bool
    default n
    help
      Include the MP2 firmwares and configuration into the PSP build.
@@ -331,7 +331,7 @@
      If unsure, answer 'n'

config PSP_LOAD_S0I3_FW
-	bool "Include S0I3 blob in PSP build"
+	bool
    default n
    help
      Select this item to include the S0i3 file into the PSP build.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop some Kconfig options from being user-visible
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/40699/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40699/1//COMMIT_MSG@7 
PS1, Line 7: Drop some Kconfig options from being user-visible
Since a "prompt" is what you see in menuconfig, maybe say:

Drop prompts from some Kconfig options

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop some Kconfig options from being user-visible
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40699/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40699/1//COMMIT_MSG@7 
PS1, Line 7: Drop some Kconfig options from being user-visible
> Since a "prompt" is what you see in menuconfig, maybe say: […]

Done

Change in coreboot[master]: soc/amd/picasso: Drop prompts from some Kconfig options

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Angel Pons, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40699

to look at the new patch set (#2).

Change subject: soc/amd/picasso: Drop prompts from some Kconfig options
......................................................................

soc/amd/picasso: Drop prompts from some Kconfig options

Some of the PSP Kconfig options that are prompted to the user should
really be selected by mainboard. This change updates such options to
not make them user-visible any more.

BUG=b:154880818

Change-Id: Iaff02fb1e720e0562b740799593322e59b022212
Signed-off-by: Furquan Shaikh 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/40699/2

Change in coreboot[master]: soc/amd/picasso: Drop prompts from some Kconfig options

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop prompts from some Kconfig options
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig 
File src/soc/amd/picasso/Kconfig:

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig... 
PS2, Line 224: 	bool
https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds...

https://ticket.coreboot.org/issues/224

Change in coreboot[master]: soc/amd/picasso: Drop prompts from some Kconfig options

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop prompts from some Kconfig options
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig 
File src/soc/amd/picasso/Kconfig:

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig... 
PS2, Line 265: string "AMD public Key"
You may want to consider keeping this one since it helps locate all blobs in Makefile.inc.  IIRC, for symbols without a prompt, you cannot override the default using make olddefconfig.

Side note, we may want to consider using different mechanisms in Makefile.inc for finding keys & PSP blobs vs. BIOS type blobs like APCBs, ABLs, etc.

Change in coreboot[master]: soc/amd/picasso: Drop prompts from some Kconfig options

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop prompts from some Kconfig options
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig 
File src/soc/amd/picasso/Kconfig:

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig... 
PS2, Line 265: string "AMD public Key"
> You may want to consider keeping this one since it helps locate all blobs in Makefile.inc. […]

Let's keep it this way for now. And follow-up by adding a proper Kconfig for PATH. I don't think we need to derive it from the path of a file. Instead we should have a Kconfig for path and that can be used for blobs and keys or have separate Kconfigs for paths for keys and paths.

https://review.coreboot.org/c/coreboot/+/40699/2/src/soc/amd/picasso/Kconfig... 
PS2, Line 224: 	bool
> https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds... […]

Thanks Kyosti! Yes, I think this can be removed as a follow-up. For this change, I was focussing only on the prompts for now.

Change in coreboot[master]: soc/amd/picasso: Drop prompts from some Kconfig options

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40699 )

Change subject: soc/amd/picasso: Drop prompts from some Kconfig options
......................................................................

soc/amd/picasso: Drop prompts from some Kconfig options

Some of the PSP Kconfig options that are prompted to the user should
really be selected by mainboard. This change updates such options to
not make them user-visible any more.

BUG=b:154880818

Change-Id: Iaff02fb1e720e0562b740799593322e59b022212
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40699
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 384e8a8..a37f543 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -227,7 +227,7 @@
 menu "PSP Configuration Options"

config AMDFW_OUTSIDE_CBFS
-	bool "The AMD firmware is outside CBFS"
+	bool
    default n
    help
      The AMDFW (PSP) is typically locatable in cbfs.  Select this
@@ -268,11 +268,11 @@
    depends on AMD_FWM_POSITION_INDEX = 5

config AMD_PUBKEY_FILE
-	string "AMD public Key"
+	string
    default "3rdparty/blobs/soc/amd/picasso/PSP/AmdPubKeyRV.bin"

config PSP_APCB_FILE
-	string "APCB file"
+	string
    help
      The name of the AGESA Parameter Customization Block.  This image is
      instance ID 0 in the PSP's BIOS Directory Table.
@@ -321,7 +321,7 @@
      size the flash device can erase.

config USE_PSPSCUREOS
-	bool "Include PSP SecureOS blobs in PSP build"
+	bool
    default y
    help
      Include the PspSecureOs and PspTrustlet binaries in the PSP build.
@@ -329,7 +329,7 @@
      If unsure, answer 'y'

config PSP_LOAD_MP2_FW
-	bool "Include MP2 blobs in PSP build"
+	bool
    default n
    help
      Include the MP2 firmwares and configuration into the PSP build.
@@ -337,7 +337,7 @@
      If unsure, answer 'n'

config PSP_LOAD_S0I3_FW
-	bool "Include S0I3 blob in PSP build"
+	bool
    default n
    help
      Select this item to include the S0i3 file into the PSP build.