Change in coreboot[master]: superio/smsc/sio1036: Support 16-bit IO port addressing

[Nikolai Vyssotski (Code Review)]

Nikolai Vyssotski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47647 )

Change subject: superio/smsc/sio1036: Support 16-bit IO port addressing
......................................................................

superio/smsc/sio1036: Support 16-bit IO port addressing

SMSC/Microchip 1036 can be strapped to 4E/4D and 164E/164D so make 
source code support 16 bits addressing.

Change-Id: I2bbe6f5b6dbd74299b34b0717e618dc736e7ad6f
Signed-off-by: Nikolai Vyssotski 
---
M src/superio/smsc/sio1036/sio1036_early_init.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/47647/1

diff --git a/src/superio/smsc/sio1036/sio1036_early_init.c b/src/superio/smsc/sio1036/sio1036_early_init.c
index a65f672..c4a580a 100644
--- a/src/superio/smsc/sio1036/sio1036_early_init.c
+++ b/src/superio/smsc/sio1036/sio1036_early_init.c
@@ -10,13 +10,13 @@

static inline void sio1036_enter_conf_state(pnp_devfn_t dev)
 {
-	u8 port = dev >> 8;
+	u16 port = dev >> 8;
    outb(0x55, port);
 }

static inline void sio1036_exit_conf_state(pnp_devfn_t dev)
 {
-	u8 port = dev >> 8;
+	u16 port = dev >> 8;
    outb(0xaa, port);
 }

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47647 )

Change subject: superio/smsc/sio1036: Support 16-bit IO port addressing
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47647 )

Change subject: superio/smsc/sio1036: Support 16-bit IO port addressing
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47647 )

Change subject: superio/smsc/sio1036: Support 16-bit IO port addressing
......................................................................

superio/smsc/sio1036: Support 16-bit IO port addressing

SMSC/Microchip 1036 can be strapped to 4E/4D and 164E/164D so make 
source code support 16 bits addressing.

Change-Id: I2bbe6f5b6dbd74299b34b0717e618dc736e7ad6f
Signed-off-by: Nikolai Vyssotski 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47647
Tested-by: build bot (Jenkins) 
Reviewed-by: Marshall Dawson 
Reviewed-by: Felix Held 
---
M src/superio/smsc/sio1036/sio1036_early_init.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Marshall Dawson: Looks good to me, approved

diff --git a/src/superio/smsc/sio1036/sio1036_early_init.c b/src/superio/smsc/sio1036/sio1036_early_init.c
index a65f672..c4a580a 100644
--- a/src/superio/smsc/sio1036/sio1036_early_init.c
+++ b/src/superio/smsc/sio1036/sio1036_early_init.c
@@ -10,13 +10,13 @@

static inline void sio1036_enter_conf_state(pnp_devfn_t dev)
 {
-	u8 port = dev >> 8;
+	u16 port = dev >> 8;
    outb(0x55, port);
 }

static inline void sio1036_exit_conf_state(pnp_devfn_t dev)
 {
-	u8 port = dev >> 8;
+	u16 port = dev >> 8;
    outb(0xaa, port);
 }