HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46244 )
Change subject: mb/intel/adlrvp/dsdt.asl: Use macro for DSDT revision ......................................................................
mb/intel/adlrvp/dsdt.asl: Use macro for DSDT revision
Change-Id: I6f4d0bf9adc1cce4942a16675a072ffea00bd2e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/adlrvp/dsdt.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/46244/1
diff --git a/src/mainboard/intel/adlrvp/dsdt.asl b/src/mainboard/intel/adlrvp/dsdt.asl index fca3242..6163d01 100644 --- a/src/mainboard/intel/adlrvp/dsdt.asl +++ b/src/mainboard/intel/adlrvp/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + ACPI_DSDT_REV_2, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46244 )
Change subject: mb/intel/adlrvp/dsdt.asl: Use macro for DSDT revision ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46244 )
Change subject: mb/intel/adlrvp/dsdt.asl: Use macro for DSDT revision ......................................................................
mb/intel/adlrvp/dsdt.asl: Use macro for DSDT revision
Change-Id: I6f4d0bf9adc1cce4942a16675a072ffea00bd2e0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46244 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/intel/adlrvp/dsdt.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/mainboard/intel/adlrvp/dsdt.asl b/src/mainboard/intel/adlrvp/dsdt.asl index fca3242..6163d01 100644 --- a/src/mainboard/intel/adlrvp/dsdt.asl +++ b/src/mainboard/intel/adlrvp/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + ACPI_DSDT_REV_2, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)