Attention is currently required from: Amanda Hwang, Ian Feng, Pranava Y N.
Dtrain Hsu has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/85037?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat/var/francka: Update gpio settings
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/fatcat/variants/francka/gpio.c:
https://review.coreboot.org/c/coreboot/+/85037/comment/b423c9cf_addee43e?usp... :
PS6, Line 62: ISH_GP_1_SNSR_HDR
Please modify the pin name.
https://review.coreboot.org/c/coreboot/+/85037/comment/ebc9c4a3_edf62d51?usp... :
PS6, Line 390: /* GPP_V13: GPP_V13_CATERR_N */
: PAD_CFG_NF(GPP_V13, NONE, DEEP, NF1),
: /* GPP_V14: GPP_V14_FORCEPR_N */
: PAD_CFG_NF(GPP_V14, NONE, DEEP, NF1),
: /* GPP_V15: GPP_V15_THERMTRIP_N */
: PAD_CFG_NF(GPP_V15, NONE, DEEP, NF1),
Please check settings with EE, I didn't see the settings in the GPIO table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85037?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I759df174a47a08319c1ada649d8bfb6f64b5aecd
Gerrit-Change-Number: 85037
Gerrit-PatchSet: 6
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 11 Nov 2024 09:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No