Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31137
Change subject: siemens/mc_apl2: Correct whitespaces of devicetree ......................................................................
siemens/mc_apl2: Correct whitespaces of devicetree
Change-Id: Ie0e11b1ce6c6acb1b74ce1196304f7e6ac4664d9 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31137/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index d2d5394..e54444a 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -84,17 +84,17 @@ device i2c 0x32 on end # RTC RX6110 SA end end - device pci 16.1 on end # - I2C 1 - device pci 16.2 on end # - I2C 2 - device pci 16.3 on end # - I2C 3 - device pci 17.0 on end # - I2C 4 - device pci 17.1 on end # - I2C 5 - device pci 17.2 on end # - I2C 6 + device pci 16.1 on end # - I2C 1 + device pci 16.2 on end # - I2C 2 + device pci 16.3 on end # - I2C 3 + device pci 17.0 on end # - I2C 4 + device pci 17.1 on end # - I2C 5 + device pci 17.2 on end # - I2C 6 device pci 17.3 on end # - I2C 7 - device pci 18.0 on end # - UART 0 - device pci 18.1 on end # - UART 1 - device pci 18.2 on end # - UART 2 - device pci 18.3 on end # - UART 3 + device pci 18.0 on end # - UART 0 + device pci 18.1 on end # - UART 1 + device pci 18.2 on end # - UART 2 + device pci 18.3 on end # - UART 3 device pci 19.0 off end # - SPI 0 device pci 19.1 off end # - SPI 1 device pci 19.2 off end # - SPI 2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespaces of devicetree ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespaces of devicetree ......................................................................
Patch Set 1: Code-Review+2
Thank you!
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespaces of devicetree ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG@7 PS1, Line 7: whitespaces *whitespace* is already plural I believe (uncountable).
Hello Werner Zeh, Angel Pons, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31137
to look at the new patch set (#2).
Change subject: siemens/mc_apl2: Correct whitespace of devicetree ......................................................................
siemens/mc_apl2: Correct whitespace of devicetree
Change-Id: Ie0e11b1ce6c6acb1b74ce1196304f7e6ac4664d9 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31137/2
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespace of devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG@7 PS1, Line 7: whitespaces
*whitespace* is already plural I believe (uncountable).
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespace of devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31137/1//COMMIT_MSG@7 PS1, Line 7: whitespaces
Done
FWIW, "whitespace" is uncountable, so it remains the same. If somebody wanted to use a plural form, "whitespace characters" could be used instead.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31137 )
Change subject: siemens/mc_apl2: Correct whitespace of devicetree ......................................................................
siemens/mc_apl2: Correct whitespace of devicetree
Change-Id: Ie0e11b1ce6c6acb1b74ce1196304f7e6ac4664d9 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/31137 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb 1 file changed, 10 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb index d2d5394..e54444a 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb @@ -84,17 +84,17 @@ device i2c 0x32 on end # RTC RX6110 SA end end - device pci 16.1 on end # - I2C 1 - device pci 16.2 on end # - I2C 2 - device pci 16.3 on end # - I2C 3 - device pci 17.0 on end # - I2C 4 - device pci 17.1 on end # - I2C 5 - device pci 17.2 on end # - I2C 6 + device pci 16.1 on end # - I2C 1 + device pci 16.2 on end # - I2C 2 + device pci 16.3 on end # - I2C 3 + device pci 17.0 on end # - I2C 4 + device pci 17.1 on end # - I2C 5 + device pci 17.2 on end # - I2C 6 device pci 17.3 on end # - I2C 7 - device pci 18.0 on end # - UART 0 - device pci 18.1 on end # - UART 1 - device pci 18.2 on end # - UART 2 - device pci 18.3 on end # - UART 3 + device pci 18.0 on end # - UART 0 + device pci 18.1 on end # - UART 1 + device pci 18.2 on end # - UART 2 + device pci 18.3 on end # - UART 3 device pci 19.0 off end # - SPI 0 device pci 19.1 off end # - SPI 1 device pci 19.2 off end # - SPI 2
-
Angel Pons (Code Review) -
Mario Scheithauer (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)