Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63967 )
Change subject: soc/amd/common/block/psp/psp_gen2: drop unneeded variable initialization ......................................................................
soc/amd/common/block/psp/psp_gen2: drop unneeded variable initialization
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I9a3ec9565e660d5fad61c7e73d56f2f821e152aa Reviewed-on: https://review.coreboot.org/c/coreboot/+/63967 Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/psp/psp_gen2.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/psp/psp_gen2.c b/src/soc/amd/common/block/psp/psp_gen2.c index e8d57fd..12f5fec 100644 --- a/src/soc/amd/common/block/psp/psp_gen2.c +++ b/src/soc/amd/common/block/psp/psp_gen2.c @@ -34,7 +34,7 @@
static u16 rd_mbox_sts(uintptr_t psp_mmio) { - union pspv2_mbox_command tmp = { .val = 0 }; + union pspv2_mbox_command tmp;
tmp.val = read32p(psp_mmio + PSP_MAILBOX_COMMAND_OFFSET); return tmp.fields.mbox_status; @@ -51,7 +51,7 @@
static u8 rd_mbox_recovery(uintptr_t psp_mmio) { - union pspv2_mbox_command tmp = { .val = 0 }; + union pspv2_mbox_command tmp;
tmp.val = read32p(psp_mmio + PSP_MAILBOX_COMMAND_OFFSET); return !!tmp.fields.recovery;