Change in ...coreboot[master]: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

10 Jun 2019 10 Jun '19

4:53 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33363

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions

Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdmct/mct/mctardk3.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/33363/1

diff --git a/src/northbridge/amd/amdmct/mct/mctardk3.c b/src/northbridge/amd/amdmct/mct/mctardk3.c index ce79a52..a1dfb9ba 100644 --- a/src/northbridge/amd/amdmct/mct/mctardk3.c +++ b/src/northbridge/amd/amdmct/mct/mctardk3.c @@ -99,7 +99,7 @@ } else { val &= valx; if (val != 0) { - if (pDCTstat->Speed == 3 || pDCTstat->Speed == 3) { + if (pDCTstat->Speed == 3) { pDCTstat->CH_ADDR_TMG[dct] &= 0xFFFF00FF; pDCTstat->CH_ADDR_TMG[dct] |= 0x00002F00; }

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Jacob Garber (Code Review)

10 Jun 10 Jun

10:21 a.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33363/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33363/1//COMMIT_MSG@11 PS1, Line 11: This is also a Coverity issue, so also add

Found-by: Coverity CID 1229583

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 17:21:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Marshall Dawson (Code Review)

11:17 a.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 1: Code-Review+2

My initial thought is this might've been a typo (i.e. bug) instead of poor form.

If it's a bug, my preference is to fix it instead of removing the poor form. But I haven't had time to nose around to see where this originally came from, dig into what the DCT settings are doing, if the AMD source might've been corrected later, etc. I also note that on l.75 this code is already limited to ->Speed of 3 or 4.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 18:17:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

11:37 a.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 1:

...

Patch Set 1: Code-Review+2

My initial thought is this might've been a typo (i.e. bug) instead of poor form.

If it's a bug, my preference is to fix it instead of removing the poor form. But I haven't had time to nose around to see where this originally came from, dig into what the DCT settings are doing, if the AMD source might've been corrected later, etc. I also note that on l.75 this code is already limited to ->Speed of 3 or 4.

I had originally proposed the typo idea here

https://review.coreboot.org/c/coreboot/+/33211

though we were unable to decide if it actually was a typo or not.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 18:37:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:08 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33363/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33363/1//COMMIT_MSG@11 PS1, Line 11:

...

This is also a Coverity issue, so also add […]

Oops, Sorry I didn't pay attention... it is also found here: https://qa.coreboot.org/job/coreboot-gerrit/96018/console

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 19:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:22 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 1: Code-Review-1

see https://review.coreboot.org/c/coreboot/+/33211/1/src/northbridge/amd/amdmct/...

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 10 Jun 2019 19:22:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:46 p.m.

HAOUAS Elyes has removed a vote on this change.

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: deleteVote

Angel Pons (Code Review)

11 Jun 11 Jun

10:32 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Patch Set 2: Code-Review-1

Should be superseded by https://review.coreboot.org/c/coreboot/+/33211

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Timothy Pearson tpearson@raptorengineering.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 11 Jun 2019 17:32:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:59 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33363 )

Change subject: nb/amd/amdmct/mct/mctardk3.c: Fix logical 'or' of equal expressions ......................................................................

Abandoned

see 33211

-- To view, visit https://review.coreboot.org/c/coreboot/+/33363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I980b1098b30470bd7b99b3a9920e6069c1e3580e Gerrit-Change-Number: 33363 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Timothy Pearson tpearson@raptorengineering.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1985

days inactive

1986

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Jacob Garber (Code Review)
Marshall Dawson (Code Review)