Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37181 )
Change subject: security/vboot: Remove duplicate offsetof() definition ......................................................................
security/vboot: Remove duplicate offsetof() definition
This macro is already defined in commonlib/helpers.h
Change-Id: I1fce2936757b13807e254f4a844f583b938bf349 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M src/security/vboot/secdata_tpm.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/37181/1
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index 38a1810..2fbb30b 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -40,10 +40,6 @@ #include <vb2_api.h> #include <console/console.h>
-#ifndef offsetof -#define offsetof(A,B) __builtin_offsetof(A,B) -#endif - #ifdef FOR_TEST #include <stdio.h> #define VBDEBUG(format, args...) printf(format, ## args)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37181 )
Change subject: security/vboot: Remove duplicate offsetof() definition ......................................................................
Patch Set 1: Code-Review+2
Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37181 )
Change subject: security/vboot: Remove duplicate offsetof() definition ......................................................................
Patch Set 1: Code-Review+1
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37181 )
Change subject: security/vboot: Remove duplicate offsetof() definition ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37181 )
Change subject: security/vboot: Remove duplicate offsetof() definition ......................................................................
security/vboot: Remove duplicate offsetof() definition
This macro is already defined in commonlib/helpers.h
Change-Id: I1fce2936757b13807e254f4a844f583b938bf349 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/37181 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Alex James theracermaster@gmail.com Reviewed-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/secdata_tpm.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Julius Werner: Looks good to me, approved Alex James: Looks good to me, but someone else must approve
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c index 38a1810..2fbb30b 100644 --- a/src/security/vboot/secdata_tpm.c +++ b/src/security/vboot/secdata_tpm.c @@ -40,10 +40,6 @@ #include <vb2_api.h> #include <console/console.h>
-#ifndef offsetof -#define offsetof(A,B) __builtin_offsetof(A,B) -#endif - #ifdef FOR_TEST #include <stdio.h> #define VBDEBUG(format, args...) printf(format, ## args)
-
Alex James (Code Review) -
HAOUAS Elyes (Code Review)
-
Jacob Garber (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)