[L] Change in coreboot[main]: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84222?usp=email )

Change subject: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions
......................................................................

Patch Set 4:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84222/comment/164d88e0_d3cd723d?usp... :
PS3, Line 10: micros
> macros

Done

File src/mainboard/google/cherry/bootblock.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/41fd9806_092fe676?usp... :
PS3, Line 18: DOWN
> Shouldn't this be `UP`? And the `gpio_set_pull` call should use `ptr[i].select`.

Done

File src/soc/mediatek/common/include/soc/gpio_common.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/2f89b8df_0658740c?usp... :
PS3, Line 53: struct pad_func {
            : 	gpio_t gpio;
            : 	u8 func;
            : 	enum pull_select select;
            : };
> > An alternative is adding a struct pad_func to soc/gpio. […]

Done

File src/soc/mediatek/common/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/84222/comment/481acd20_1a843bb3?usp... :
PS3, Line 29: PAD_##name##_FUNC_##func1
> `GPIO_FUNC(name, func1)`

I leave this file unmodified.

File src/soc/mediatek/mt8183/i2c.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/b140497b_a32bffbb?usp... :
PS3, Line 56: PAD_FUNC
> If the common `PAD_FUNC` is moved back to gpio_common. […]

Yes

File src/soc/mediatek/mt8186/i2c.c:

https://review.coreboot.org/c/coreboot/+/84222/comment/30a4fdf7_4d2fb69c?usp... :
PS3, Line 111: GPIO_PULL_UP
> Use `PAD_FUNC_UP` and write `.select` here. Same for all the files.

Done