Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87167?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/starbook/tgl: Tidy GPIO comments for the retimers ......................................................................
mb/starlabs/starbook/tgl: Tidy GPIO comments for the retimers
This is a non-functional change, and only makes the GPIOs easier to read.
Change-Id: I237824415c99bf57e9617a37001383cdda4a38e6 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87167 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/tgl/gpio.c 1 file changed, 5 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 8705b13..28b3388 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -51,6 +51,11 @@ PAD_CFG_NF(GPP_C6, NONE, PWROK, NF1), /* SML Clock */ PAD_CFG_NF(GPP_C7, NONE, PWROK, NF1), /* SML Data */
+ /* Retimer */ + PAD_NC(GPP_E18, NATIVE), /* TBT0 TXD */ + PAD_NC(GPP_E19, NATIVE), /* TBT0 RXD */ + PAD_CFG_GPO(GPP_A23, 0, DEEP), /* Force Power */ + /* High-Definition Audio */ PAD_CFG_NF(GPP_R0, NATIVE, DEEP, NF1), /* Clock */ PAD_CFG_NF(GPP_R1, NATIVE, DEEP, NF1), /* Sync */ @@ -113,8 +118,6 @@ PAD_NC(GPP_A21, NONE), /* A22: Not Connected */ PAD_NC(GPP_A22, NONE), - /* A23: TC_RETIMER_FORCE_PWR */ - PAD_CFG_GPO(GPP_A23, 0, DEEP),
/* B2: VRALERT_N */ PAD_NC(GPP_B2, NONE), @@ -257,10 +260,6 @@ PAD_NC(GPP_E16, NONE), /* E17: Not Connected */ PAD_NC(GPP_E17, NONE), - /* E18: TBT_LSX0_TXD */ - PAD_NC(GPP_E18, NATIVE), - /* E19: TBT_LSX0_RXD */ - PAD_NC(GPP_E19, NATIVE), /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), /* E21: TBT_LSX1_RXD */