Change in ...coreboot[master]: mb/google/hatch: Configure touchpad GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31328

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure touchpad GPIO pad for non-inversion

This implementation configures touchpad GPIO(GPP_A21) pad
in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Verify touchpad is working fine

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31328/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index f8d5d7d..37e16ec 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -28,7 +28,7 @@
    /* WWAN_RADIO_DISABLE_1V8_ODL */
    PAD_CFG_GPO(GPP_A19, 1, DEEP),
    /* TRACKPAD_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT),
+	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE),
    /* SRCCLKREQ1 */
    PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1),
    /* PCIE_14_WLAN_CLKREQ_ODL */

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... 
PS1, Line 30: /* TRACKPAD_INT_ODL */
Can you please add a comment indicating that this is a temporary work-around and should be removed once FSP behavior is fixed.

[Aamir Bohra (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31328

to look at the new patch set (#2).

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure touchpad GPIO pad for non-inversion

This implementation configures touchpad GPIO(GPP_A21) pad
in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Verify touchpad is working fine

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 5 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31328/2

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31328/1/src/mainboard/google/hatch/variants/... 
PS1, Line 30: /* TRACKPAD_INT_ODL */
> Can you please add a comment indicating that this is a temporary work-around and should be removed o […]

Ok. Done. Please review.

[Rajat Jain (Code Review)]

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

Patch Set 2: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure touchpad GPIO pad for non-inversion
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 74: INVERT
This will be affected too.

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 90: INVERT
Same here

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 188: INVERT
Same here.

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Hello Rajat Jain, Subrata Banik, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31328

to look at the new patch set (#3).

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure GPIO pad for non-inversion

This implementation configures GPIO(GPP_A21, GPP_C21, GPP_D16)
padin non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Tested for below:
     -> Verify touchpad is working fine.
     -> TPM init is successful and boot with fixed boot media.

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 24 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31328/3

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 74: INVERT
> This will be affected too.

ok. Done

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 90: INVERT
> Same here

Done

https://review.coreboot.org/#/c/31328/2/src/mainboard/google/hatch/variants/... 
PS2, Line 188: INVERT
> Same here.

Done

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Hello Rajat Jain, Subrata Banik, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31328

to look at the new patch set (#4).

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure GPIO pad for non-inversion

This implementation configures GPIO(GPP_A21, GPP_C21, GPP_D16)
pad in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Tested for below:
     -> Verify touchpad is working fine.
     -> TPM init is successful and boot with fixed boot media.

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 24 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31328/4

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

Patch Set 4: Code-Review+2

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/31328/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31328/4//COMMIT_MSG@9 
PS4, Line 9: GPIO(GPP_A21, GPP_C21, GPP_D16)
Please add a space before the (.

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Hello Rajat Jain, Subrata Banik, Paul Menzel, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31328

to look at the new patch set (#5).

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure GPIO pad for non-inversion

This implementation configures GPIO (GPP_A21, GPP_C21, GPP_D16)
pad in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Tested for below:
     -> Verify touchpad is working fine.
     -> TPM init is successful and boot with fixed boot media.

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 24 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/31328/5

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31328/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31328/4//COMMIT_MSG@9 
PS4, Line 9: GPIO(GPP_A21, GPP_C21, GPP_D16)
> Please add a space before the (.

Done

Change in ...coreboot[master]: mb/google/hatch: Configure GPIO pad for non-inversion

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31328 )

Change subject: mb/google/hatch: Configure GPIO pad for non-inversion
......................................................................

mb/google/hatch: Configure GPIO pad for non-inversion

This implementation configures GPIO (GPP_A21, GPP_C21, GPP_D16)
pad in non-inversion mode i.e Rx PAD state is not inverted as
it is sent from GPIO to IOAPIC.

BUG=b:123315212
TEST=Tested for below:
     -> Verify touchpad is working fine.
     -> TPM init is successful and boot with fixed boot media.

Change-Id: I6034fd07ccc96a19218d57ef8bb9049c4b963ea5
Signed-off-by: Aamir Bohra 
Reviewed-on: https://review.coreboot.org/c/31328
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Paul Menzel 
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
1 file changed, 24 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index f8d5d7d..badd978 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -27,8 +27,12 @@
    PAD_CFG_GPO(GPP_A18, 1, DEEP),
    /* WWAN_RADIO_DISABLE_1V8_ODL */
    PAD_CFG_GPO(GPP_A19, 1, DEEP),
-	/* TRACKPAD_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT),
+	/*
+	 * TRACKPAD_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE),
    /* SRCCLKREQ1 */
    PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1),
    /* PCIE_14_WLAN_CLKREQ_ODL */
@@ -67,8 +71,12 @@
    PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1),
    /* PCH_WP_OD */
    PAD_CFG_GPI(GPP_C20, NONE, DEEP),
-	/* H1_PCH_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * H1_PCH_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, NONE),
    /* EC_IN_RW_OD */
    PAD_CFG_GPI(GPP_C22, NONE, DEEP),
    /* WLAN_PE_RST# */
@@ -83,8 +91,12 @@
    PAD_NC(GPP_D8, NONE),
    /* TOUCHSCREEN_RST_L */
    PAD_CFG_GPO(GPP_D15, 0, DEEP),
-	/* TOUCHSCREEN_INT_L */
-	PAD_CFG_GPI_APIC(GPP_D16, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * TOUCHSCREEN_INT_L
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_D16, NONE, DEEP, LEVEL, NONE),
    /* SATAGP1 */
    PAD_CFG_NF(GPP_E1, NONE, DEEP, NF2),
    /* M2_SSD_PE_WAKE_ODL */
@@ -181,8 +193,12 @@
    PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
    /* H1_SLAVE_SPI_MOSI_R */
    PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
-	/* H1_PCH_INT_ODL */
-	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, INVERT),
+	/*
+	 * H1_PCH_INT_ODL
+	 * TODO Configure it back to invert mode, when
+	 * ITSS IPCx configuration is fixed in FSP.
+	 */
+	PAD_CFG_GPI_APIC(GPP_C21, NONE, DEEP, LEVEL, NONE),
    /* WLAN_PE_RST# */
    PAD_CFG_GPO(GPP_C23, 1, DEEP),
 };