Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74229 )
Change subject: mb/google/rex: Update Rex Flash Layout ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74229/comment/ce283eac_1c9a5a54 PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB.
Why is that done?
what do you mean by this? we have product requirement to create 4MB WP_RO hence, we have done that.
https://review.coreboot.org/c/coreboot/+/74229/comment/20ef5cb5_3fd4e49e PS1, Line 9: This patch updates the Rex flash layout to optimize WP_RO to 4MB. : : Changes for chromeos.fmd: : : SI_BIOS: : RW_SECTION_A/B: Reduce to 7MB. : RW_LEGACY: Reduce to 1MB. : RW_MISC: Increased to 1MB. : RW_UNUSED: 3MB (reserved) : WP_RO: Reduce to 4MB : : Additionally, ensure RW_SECTION_B region starts at 16MB boundary in the : SPI Flash.
Why not make it two (or three) commits?
the goal is to reduce WP_RO to 4MB hence, in that process what all adjustment we need to do it has to be done at one shot else system will not boot.
Honestly I think these comments are not taking us anywhere. I' feeling supervised while submitting the code. I'm not feeling this is like any code review.
File src/mainboard/google/rex/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74229/comment/c990a26d_7bd9457b PS1, Line 7: 7M
I’d make these non-functional changes a separate commit.
I don't agree with this. This CL attempts to make WP_RO to 4MB hence, all relevant changes are here.
-
Subrata Banik (Code Review)