Change in coreboot[master]: mb/google/guybrush: Add the fw SPL to amdfw.cfg - coreboot-gerrit

3 Feb 2022


      Attention is currently required from: Bao Zheng, Name of user not set #1004133, Zheng Bao.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61445 )
Change subject: mb/google/guybrush: Add the fw SPL to amdfw.cfg
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/amdfw.cfg:
https://review.coreboot.org/c/coreboot/+/61445/comment/3ceb6262_ef69aafc 
PS1, Line 27: TypeId0x55_SplTable_Prod_CZN_Chrome
...
Not sure this is required upstream. […]
I think we should push it upstream at some point. Ideally we should be able to build functional firmware from the upstream repos.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/61445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268a92c9916b261fbc899ebb72f75f7a3f12c441
Gerrit-Change-Number: 61445
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: Name of user not set #1004133
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rob Barnes robbarnes@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 03 Feb 2022 16:33:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Name of user not set #1004133
Gerrit-MessageType: comment