Attention is currently required from: Michael Niewöhner, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52810 )
Change subject: soc/intel/skylake: Use set_dev_state_by_devicetree() ......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/52810/comment/d69788db_7b453779 PS1, Line 461: (!xdci_can_enable()) : params->XdciEnable = 0;
params->XdciEnable = xdci_can_enable();
Done
File src/soc/intel/skylake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52810/comment/c8946045_146feb7a PS1, Line 15:
newline?
Done
https://review.coreboot.org/c/coreboot/+/52810/comment/5a4cd086_3c65eb0b PS1, Line 137: PCH_DEVFN_SMBUS }, : { &m_cfg->EnableTraceHub, P
alignment
Done