Change in coreboot[master]: util/inteltool: gpio add code for dumping GPIO Community cfg registers
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39511 )
Change subject: util/inteltool: gpio add code for dumping GPIO Community cfg registers ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_groups.... File util/inteltool/gpio_groups.c:
https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_groups.... PS7, Line 82: if (community->community_cfg_registers) {
`_size` should be 0 too, so we don't need this `if` […]
Done
https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/g... File util/inteltool/gpio_names/gpio_groups.h:
https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/g... PS7, Line 15: size
IMO, we should stick to conventions of the closest code and (if possible) […]
Done
-
Michael Niewöhner (Code Review)